Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISLANDORA-2393 Allowing SSL connection params to be set #29

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

megwill4268
Copy link

@megwill4268 megwill4268 commented Mar 1, 2019

ISLANDORA-2393 : https://jira.duraspace.org/browse/ISLANDORA-2393

https://dev.mysql.com/doc/connector-j/8.0/en/connector-j-reference-using-ssl.html

Adding support for SSL connections to the drupal database integrated with a fedora repository. Apart for some spacing and a few comments it is just adding parsing of a few SSL connection params from the filter-drupal.xml and adding them onto to the jdbcUrl.

@manez
Copy link
Member

manez commented Mar 1, 2019

Just dropping a note that Megan does have a CLA on file, so this is all clear on that front 👍

https://github.com/Islandora/islandora/wiki/Contributor-License-Agreements

@dannylamb
Copy link

@megwill4268 How could one set up an environment to test this? Is setting up mysql to use SSL that big of a hassle? Because this looks like a solid security improvement.

I mean, have we been doing it wrong all along?

@megwill4268
Copy link
Author

I can work on setting up an automated test for this, I expected you would ask. As for the necessity of encrypting the database connection, it all depends on your architecture. Within a single server monolith it isn't so necessary. In my case our fedora and drupal databases are hosted in different networks, hence the need for encrypting and cert verification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants