Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISLANDORA-2054: fix more than one field in SORT CRITERIA of a Views #52

Merged
merged 2 commits into from
Sep 19, 2017

Conversation

giancarlobi
Copy link
Contributor

@giancarlobi giancarlobi commented Sep 6, 2017

JIRA Ticket: ISLANDORA-2054

What does this Pull Request do?

When more than one field in SORT CRITERIA of a Views, the query string is wrong:
... &sort=dc.date_dt+asc*&sort=fgs_label_s+asc& ...
instead of
... &sort=dc.date_dt+asc
,*fgs_label_s+asc& ...

What's new?

No new features

How should this be tested?

Build a views with more then one field in SORT CRITERIA.

Additional Notes:

No additional information.

Interested parties

Tag (@ mention) interested parties or, if unsure, @Islandora/7-x-1-x-committers

When more than one field in SORT CRITERIA of a Views, the query string is wrong:
... &sort=dc.date_dt+asc*&*sort=fgs_label_s+asc& ...
instead of
... &sort=dc.date_dt+asc*,*fgs_label_s+asc& ...
@DiegoPino
Copy link
Contributor

@giancarlobi thanks for this!

There are some tiny issues we need before getting this merged

1.- Travis is failing because of Drupal coding standards. According to Travis https://travis-ci.org/Islandora/islandora_solr_views/jobs/272370318#L706 there is a missing space after the comma
2.- If you could make the pull request comment/description match the format, basically moving the description of the fix after "What does this Pull Request do?", adding the JIRA ticket and URL to the JIRA to the beginning and starting the title with ISLANDORA-2054: etc. I know this all sounds picky (sorry) but helps JIRA make the connection with the pull, basically making this one appear in the JIRA ticket itself. Pluse helps people not following the list understand better the issue and review.

You can use this #39 as example for the format if you want of any other open pull request

Highly appreciate this changes and will merge once Travis passes. Thanks again!

@giancarlobi giancarlobi changed the title Solve https://jira.duraspace.org/browse/ISLANDORA-2054 ISLANDORA-2054: fix more than one field in SORT CRITERIA of a Views Sep 14, 2017
@giancarlobi
Copy link
Contributor Author

I hope I made well homeworks ...
I changed code in PR and modified title and content, is it right?
Thanks a lot @DiegoPino to be so patient !

@DiegoPino
Copy link
Contributor

Gracias @giancarlobi!! Merging now =)

@DiegoPino DiegoPino merged commit 0644a40 into Islandora:7.x Sep 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants