-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve attribution protection for images #2072
Conversation
…ttribution-protection
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #2072 +/- ##
=======================================
Coverage 90.43% 90.43%
=======================================
Files 100 100
Lines 8518 8520 +2
Branches 1071 1070 -1
=======================================
+ Hits 7703 7705 +2
Misses 586 586
Partials 229 229 ☔ View full report in Codecov by Sentry. |
Related to:
Checks the attribution in parallel for all images when converting the data of a POI to be presented.
The attribution is cached, so this should not impact performance much.
Filter out images that do not have the relevant attribution.
Changed the attribution fetching to use Wikimedia commons instead of a specific language for wikipedia, this way the mechanism is more robust and doesn't require to check the user's current language.