Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve attribution protection for images #2072

Merged
merged 16 commits into from
Nov 9, 2024
Merged

Conversation

HarelM
Copy link
Member

@HarelM HarelM commented Nov 9, 2024

Related to:

Checks the attribution in parallel for all images when converting the data of a POI to be presented.
The attribution is cached, so this should not impact performance much.
Filter out images that do not have the relevant attribution.
Changed the attribution fetching to use Wikimedia commons instead of a specific language for wikipedia, this way the mechanism is more robust and doesn't require to check the user's current language.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ zstadler
❌ HarelM
You have signed the CLA already but the status is still pending? Let us recheck it.

@codecov-commenter
Copy link

codecov-commenter commented Nov 9, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.43%. Comparing base (63508db) to head (8ef4f25).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2072   +/-   ##
=======================================
  Coverage   90.43%   90.43%           
=======================================
  Files         100      100           
  Lines        8518     8520    +2     
  Branches     1071     1070    -1     
=======================================
+ Hits         7703     7705    +2     
  Misses        586      586           
  Partials      229      229           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HarelM HarelM merged commit 36c817b into main Nov 9, 2024
6 of 7 checks passed
@HarelM HarelM deleted the improve-attribution-protection branch November 9, 2024 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants