Added support for ES modules #1
Conversation
Signed-off-by: Amit Lacher <[email protected]>
Signed-off-by: Amit Lacher <[email protected]>
Signed-off-by: Amit Lacher <[email protected]>
Signed-off-by: Amit Lacher <[email protected]>
Signed-off-by: Amit Lacher <[email protected]>
Signed-off-by: Amit Lacher <[email protected]>
Signed-off-by: Amit Lacher <[email protected]>
Signed-off-by: Amit Lacher <[email protected]>
background-wrapper.js
Outdated
| @@ -0,0 +1,23 @@ | |||
| import * as background from '/background.js' | |||
There was a problem hiding this comment.
Why do we need the wrapper?
There was a problem hiding this comment.
the wrapper is able to catch thrown errors any time anything invoked background.sdatortautoplay
helpers.js
Outdated
|
|
||
| const values = []; | ||
| for (const key in keys){ | ||
| values.push(new Promise((res) => { |
There was a problem hiding this comment.
Why did you push the value and new promise to the value?
There was a problem hiding this comment.
that's a good question
consts.js
Outdated
| @@ -0,0 +1,4 @@ | |||
| const SDAROT_USERNAME_KEY = 'sdarotUsername'; | |||
There was a problem hiding this comment.
You can add 'export' before the const declaration so you will be able to import like this - import {SDAROT_USERNAME_KEY } from './consts.js
There was a problem hiding this comment.
I tried that, maybe we can get it to work, let me check
popup.js
Outdated
| } | ||
|
|
||
| const password = document.getElementById("sdarot-auto-password").value; |
There was a problem hiding this comment.
Don't you want to insert it also to locator.js?
There was a problem hiding this comment.
probably should
| } | ||
|
|
||
| export const login = (username, password) => { | ||
| fetch("https://sdarot.buzz/login", { |
There was a problem hiding this comment.
we need to pass this function a baseURL of the current URL for this to work across multiple sites url.
No description provided.