Fix action cubit close status (#89)

* test: new isClosed logic * fix: async import
Iteo · Jan 24, 2025 · da103b0 · da103b0
1 parent 8e11780
commit da103b0
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 0 deletions.
diff --git a/lib/src/mixins/bloc_action_mixin.dart b/lib/src/mixins/bloc_action_mixin.dart
@@ -61,6 +61,9 @@ mixin BlocActionMixin<ACTION, S> on BlocBase<S> {
     previousAction = action;
   }
 
+  @override
+  bool get isClosed => super.isClosed || _streamController.isClosed;
+
   @override
   Future<void> close() async {
     previousAction = null;

diff --git a/test/mixins/bloc_action_mixin_test.dart b/test/mixins/bloc_action_mixin_test.dart
@@ -75,4 +75,29 @@ void main() {
     expect(true, cubit.actionStreamController.isClosed);
     expect(true, cubit.isClosed);
   });
+
+  testWidgets('should be closed when either state or action stream is closed',
+      (tester) async {
+    final cubit = TestCubitWithMixin();
+    when(() => injector.get<TestCubitWithMixin>()).thenReturn(cubit);
+
+    Future<void> build() async {
+      await tester.pumpWidget(
+        HookedBlocConfigProvider(
+          injector: () => injector.get,
+          child: HookBuilder(
+            builder: (context) {
+              useBloc<TestCubitWithMixin>();
+
+              return const SizedBox();
+            },
+          ),
+        ),
+      );
+    }
+
+    await build();
+    await cubit.actionStreamController.close();
+    expect(true, cubit.isClosed);
+  });
 }