Fix Bugs 05/04/2024 #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codepuncher
reviewed
Apr 5, 2024
codepuncher
reviewed
Apr 5, 2024
codepuncher
reviewed
Apr 5, 2024
codepuncher
reviewed
Apr 5, 2024
codepuncher
reviewed
Apr 5, 2024
Comment on lines
+15
to
+24
| window.gform.addAction( | ||
| 'gform_input_change', | ||
| function (elem) { | ||
| if ( | ||
| !(elem instanceof HTMLInputElement) || | ||
| !elem.closest(totalSelector) || | ||
| !elem.value | ||
| ) { | ||
| return; | ||
| } |
There was a problem hiding this comment.
this is what the formatter wanted
There was a problem hiding this comment.
just leaves in the breeze,
drifting onwards, no control,
formatter decides
codepuncher
reviewed
Apr 5, 2024
Comment on lines
+37
to
+40
| $exists = GFAPI::form_id_exists($form_id); | ||
| if (empty($exists)) { | ||
| return; | ||
| } |
There was a problem hiding this comment.
Suggested change
| $exists = GFAPI::form_id_exists($form_id); | |
| if (empty($exists)) { | |
| return; | |
| } | |
| if (! GFAPI::form_id_exists($form_id)) { | |
| return; | |
| } |
stop doing empty checks on boolssssss!!!!!!
There was a problem hiding this comment.
theres literally no harm in doing it - it just adds an extra layer of safety in case the function doesnt do what its docblock says
codepuncher
reviewed
Apr 5, 2024
Comment on lines
+57
to
+58
| <option value="">--Please select a field--</option> | ||
|
|
There was a problem hiding this comment.
Suggested change
| <option value="">--Please select a field--</option> |
codepuncher
reviewed
Apr 5, 2024
codepuncher
reviewed
Apr 5, 2024
codepuncher
reviewed
Apr 5, 2024
codepuncher
reviewed
Apr 5, 2024
codepuncher
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Current Bugs 05/04/2024
Not Checking the total selector field
The section of JS checking if the field was the correct input was removed.
Values displaying Nan after number input adds pound sign
When clicking off the input the number field automatically adds the pound sign.
This cant be converted to a float so returns a NaN value - as this is still technically not empty it passes this through to the values.
Chosen field not being saved in the dropdown in editor
The field builder currently doesn't show the saved value of the chosen field in the dropdown.
gift-aid-not-saving.mp4