Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(GiftAidField): fix gift donation total missing pound sign; #17

Merged
merged 2 commits into from
Nov 27, 2024

Conversation

scriptovski
Copy link
Contributor

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug fix
  • Breaking change
  • Requires manual action post-deploy
  • Optimisation
  • Documentation update

Description

fix(GiftAidField): fix gift donation total missing pound sign;

Related Tickets & Documents

QA Instructions, Screenshots, Recordings

Please replace this line with instructions on how to test your changes, a note
on the devices and browsers this has been tested on, as well as any relevant
images for UI changes.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Checked with axe DevTools and addressed Critical and Serious AA issues
    • Insert a screenshot of Axe Scan with 0 issues here

Deployment checklist

Before deploying, ensure you have completed this checklist:

  • I have deployed this PR to staging and I can confirm the behaviour is expected/correct

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

You can find GIFs here or here

alt_text_here

@scriptovski scriptovski requested a review from a team November 25, 2024 15:11
@codepuncher codepuncher marked this pull request as draft November 25, 2024 15:13
@codepuncher
Copy link
Member

Once this has been deployed to a staging site and tested, we can review and merge 👍

@scriptovski scriptovski marked this pull request as ready for review November 27, 2024 10:38
@scriptovski
Copy link
Contributor Author

Once this has been deployed to a staging site and tested, we can review and merge 👍

Pushed LIVE to UAT, tested. Seems works well:
image

codepuncher
codepuncher previously approved these changes Nov 27, 2024
@codepuncher codepuncher dismissed their stale review November 27, 2024 10:44

Need version number change

@scriptovski scriptovski merged commit 4e8d5fe into main Nov 27, 2024
2 checks passed
@scriptovski scriptovski deleted the fix-donation-amount-missing-pound-sign branch November 27, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants