Fix issue 2933 (#2959)

* updated fake transaction dao * implement fake transaction dao test
Ivy-Apps · Feb 14, 2024 · 26bb0dc · 26bb0dc
1 parent 3430fb4
commit 26bb0dc
Show file tree

Hide file tree

Showing 2 changed files with 3,088 additions and 4 deletions.
diff --git a/shared/data/src/main/java/com/ivy/data/db/dao/fake/FakeTransactionDao.kt b/shared/data/src/main/java/com/ivy/data/db/dao/fake/FakeTransactionDao.kt
@@ -68,6 +68,7 @@ class FakeTransactionDao : TransactionDao, WriteTransactionDao {
         return items.filter {
             val dateTime = it.dateTime ?: return@filter false
             it.type == TransactionType.TRANSFER &&
+                    it.toAccountId == toAccountId &&
                     isBetween(dateTime, startDate, endDate) &&
                     !it.isDeleted
         }.sortedByDescending { it.dateTime }
@@ -292,15 +293,20 @@ class FakeTransactionDao : TransactionDao, WriteTransactionDao {
     }
 
     override suspend fun save(value: TransactionEntity) {
-        items.add(value)
+        val existingItemIndex = items.indexOfFirst { it.id == value.id }
+        if (existingItemIndex > -1) {
+            items[existingItemIndex] = value
+        } else {
+            items.add(value)
+        }
     }
 
     override suspend fun saveMany(values: List<TransactionEntity>) {
         values.forEach { save(it) }
     }
 
     override suspend fun flagDeleted(id: UUID) {
-        items.map {
+        items.replaceAll {
             if (it.id == id) {
                 it.copy(isDeleted = true)
             } else {
@@ -310,7 +316,7 @@ class FakeTransactionDao : TransactionDao, WriteTransactionDao {
     }
 
     override suspend fun flagDeletedByRecurringRuleIdAndNoDateTime(recurringRuleId: UUID) {
-        items.map {
+        items.replaceAll {
             if (it.recurringRuleId == recurringRuleId && it.dateTime == null) {
                 it.copy(isDeleted = true)
             } else {
@@ -320,7 +326,7 @@ class FakeTransactionDao : TransactionDao, WriteTransactionDao {
     }
 
     override suspend fun flagDeletedByAccountId(accountId: UUID) {
-        items.map {
+        items.replaceAll {
             if (it.accountId == accountId) {
                 it.copy(isDeleted = true)
             } else {