Fix for : EditTransactionViewModel.kt:859:24: This condition is too c…

…omplex (4). Defined complexity threshold for conditions is set to '4' [ComplexCondition]
Ivy-Apps · Sep 14, 2024 · 5104802 · 5104802
1 parent 473f87a
commit 5104802
Showing 1 changed file with 13 additions and 3 deletions.
diff --git a/screen/edit-transaction/src/main/java/com/ivy/transaction/EditTransactionViewModel.kt b/screen/edit-transaction/src/main/java/com/ivy/transaction/EditTransactionViewModel.kt
@@ -856,9 +856,10 @@ class EditTransactionViewModel @Inject constructor(
             }
 
             val exRate = exchangeRate
-                ?: if (
-                    customExchangeRateState.showCard && toAccCurrencyCode == customExchangeRateState.toCurrencyCode &&
-                    fromAccCurrencyCode == customExchangeRateState.fromCurrencyCode && !resetRate
+                ?: if (isCustomExchangeRateCurrencyCodeMatchingWithSourceAndDestinationAccountCurrencyCode(
+                        toAccCurrencyCode = toAccCurrencyCode,
+                        fromAccCurrencyCode = fromAccCurrencyCode
+                    ) && !resetRate
                 ) {
                     customExchangeRateState.exchangeRate
                 } else {
@@ -887,6 +888,15 @@ class EditTransactionViewModel @Inject constructor(
         }
     }
 
+    private fun isCustomExchangeRateCurrencyCodeMatchingWithSourceAndDestinationAccountCurrencyCode(
+        toAccCurrencyCode: String,
+        fromAccCurrencyCode: String
+    ): Boolean {
+        return customExchangeRateState.showCard &&
+                toAccCurrencyCode == customExchangeRateState.toCurrencyCode &&
+                fromAccCurrencyCode == customExchangeRateState.fromCurrencyCode
+    }
+
     private fun saveIfEditMode(closeScreen: Boolean = false) {
         if (editMode) {
             hasChanges = true