fix detekt

.github/workflows/compose_screenshot_test.yml

@@ -29,11 +29,11 @@ jobs:
           restore-keys: |
             ${{ runner.os }}-gradle-
       - name: Run Compose preview screenshot tests
-        run: ./gradlew :shared:ui:testing:validateDebugScreenshotTest
+        run: ./gradlew :screen:disclaimer:validateDebugScreenshotTest
 
       - name: Upload build reports
         uses: actions/upload-artifact@v4
         if: always()
         with:
           name: my-artifact
-          path: shared/ui/testing/build/reports
+          path: screen/disclaimer/build/reports

buildSrc/src/main/kotlin/BuildConfigConstants.kt

@@ -0,0 +1,3 @@
+object BuildConfigConstants {
+    const val IMAGE_DIFFERENCE_THRESHOLD = 0.06f
+}

screen/accounts/src/main/java/com/ivy/accounts/AccountsTab.kt

@@ -27,7 +27,6 @@ import androidx.compose.ui.graphics.toArgb
 import androidx.compose.ui.platform.testTag
 import androidx.compose.ui.res.stringResource
 import androidx.compose.ui.text.font.FontWeight
-import androidx.compose.ui.tooling.preview.Preview
 import androidx.compose.ui.unit.dp
 import androidx.compose.ui.unit.sp
 import com.ivy.base.legacy.Theme

screen/attributions/src/main/java/com/ivy/attributions/AttributionsScreen.kt

@@ -25,7 +25,6 @@ import androidx.compose.ui.Modifier
 import androidx.compose.ui.platform.LocalUriHandler
 import androidx.compose.ui.res.stringResource
 import androidx.compose.ui.text.style.TextOverflow
-import androidx.compose.ui.tooling.preview.Preview
 import androidx.compose.ui.unit.dp
 import com.ivy.navigation.IvyPreview
 import com.ivy.navigation.Navigation

screen/budgets/src/main/java/com/ivy/budgets/BudgetScreen.kt

@@ -449,7 +449,6 @@ private fun Preview_Budgets(theme: Theme = Theme.LIGHT) {
     }
 }
 
-
 /** For screenshot testing */
 @Composable
 fun BudgetScreenUiTest(isDark: Boolean) {

screen/categories/src/main/java/com/ivy/categories/CategoriesScreen.kt

@@ -682,12 +682,14 @@ private fun SelectTypeButton(
     }
 }
 
+@Suppress("UnusedPrivateMember")
 @IvyPreviews
 @Composable
 private fun PreviewCategoriesCompactModeEnabled(theme: Theme = Theme.LIGHT) {
     Preview(theme = theme, compactModeEnabled = true)
 }
 
+@Suppress("UnusedPrivateMember")
 @IvyPreviews
 @Composable
 private fun PreviewCategoriesCompactModeEnabledAndSearchBarEnabled(theme: Theme = Theme.LIGHT) {

screen/edit-transaction/src/main/java/com/ivy/transaction/EditTransactionScreen.kt

@@ -28,7 +28,6 @@ import androidx.compose.ui.platform.LocalView
 import androidx.compose.ui.res.stringResource
 import androidx.compose.ui.text.font.FontWeight
 import androidx.compose.ui.text.input.TextFieldValue
-import androidx.compose.ui.tooling.preview.Preview
 import androidx.compose.ui.unit.dp
 import com.ivy.base.legacy.Theme
 import com.ivy.base.model.TransactionType

screen/features/src/main/java/com/ivy/features/FeaturesScreen.kt

@@ -162,7 +162,6 @@ private fun FeatureRow(
     }
 }
 
-
 @IvyPreviews
 @Composable
 private fun FeatureScreenPreview(isDark: Boolean = false) {
@@ -202,4 +201,3 @@ private fun FeatureScreenPreview(isDark: Boolean = false) {
 fun FeatureScreenUiTest(isDark: Boolean) {
     FeatureScreenPreview(isDark)
 }
-

screen/import-data/src/main/java/com/ivy/importdata/csvimport/ImportScreen.kt

@@ -6,18 +6,17 @@ import androidx.compose.runtime.Composable
 import androidx.compose.runtime.getValue
 import androidx.compose.runtime.livedata.observeAsState
 import androidx.compose.ui.platform.LocalContext
-import androidx.compose.ui.tooling.preview.Preview
 import androidx.lifecycle.viewmodel.compose.viewModel
 import com.ivy.base.legacy.Theme
+import com.ivy.data.backup.ImportResult
 import com.ivy.importdata.csvimport.flow.ImportFrom
 import com.ivy.importdata.csvimport.flow.ImportProcessing
 import com.ivy.importdata.csvimport.flow.ImportResultUI
 import com.ivy.importdata.csvimport.flow.instructions.ImportInstructions
+import com.ivy.legacy.IvyWalletPreview
 import com.ivy.legacy.domain.deprecated.logic.csv.model.ImportType
 import com.ivy.navigation.ImportScreen
 import com.ivy.onboarding.viewmodel.OnboardingViewModel
-import com.ivy.data.backup.ImportResult
-import com.ivy.legacy.IvyWalletPreview
 import com.ivy.ui.annotation.IvyPreviews
 
 @OptIn(ExperimentalStdlibApi::class)

screen/loans/src/main/java/com/ivy/loans/loandetails/LoanDetailsScreen.kt

@@ -30,7 +30,6 @@ import androidx.compose.ui.platform.testTag
 import androidx.compose.ui.res.stringResource
 import androidx.compose.ui.text.font.FontWeight
 import androidx.compose.ui.text.style.TextAlign
-import androidx.compose.ui.tooling.preview.Preview
 import androidx.compose.ui.unit.dp
 import androidx.lifecycle.viewmodel.compose.viewModel
 import com.ivy.base.legacy.Theme
@@ -103,10 +102,11 @@ fun BoxWithConstraintsScope.LoanDetailsScreen(screen: LoanDetailsScreen) {
     )
 }
 
+@Suppress("LongMethod")
 @Composable
 private fun BoxWithConstraintsScope.UI(
     state: LoanDetailsScreenState,
-    onEventHandler: (LoanDetailsScreenEvent) -> Unit = {}
+    onEventHandler: (LoanDetailsScreenEvent) -> Unit = {},
 ) {
     val itemColor = state.loan?.color?.toComposeColor() ?: Gray
 
@@ -203,17 +203,24 @@ private fun BoxWithConstraintsScope.UI(
     }
 
     LoanModal(
-        modal = state.loanModalData, onCreateLoan = {
-        // do nothing
-    }, onEditLoan = { loan, createLoanTransaction ->
-        onEventHandler.invoke(LoanModalEvent.OnEditLoanModal(loan, createLoanTransaction))
-    }, dismiss = {
-        onEventHandler.invoke(LoanModalEvent.OnDismissLoanModal)
-    }, onCreateAccount = { createAccountData ->
-        onEventHandler.invoke(LoanDetailsScreenEvent.OnCreateAccount(createAccountData))
-    }, accounts = state.accounts, onPerformCalculations = {
-        onEventHandler.invoke(LoanModalEvent.PerformCalculation)
-    }, dateTime = state.dateTime,
+        modal = state.loanModalData,
+        onCreateLoan = {
+            // do nothing
+        },
+        onEditLoan = { loan, createLoanTransaction ->
+            onEventHandler.invoke(LoanModalEvent.OnEditLoanModal(loan, createLoanTransaction))
+        },
+        dismiss = {
+            onEventHandler.invoke(LoanModalEvent.OnDismissLoanModal)
+        },
+        onCreateAccount = { createAccountData ->
+            onEventHandler.invoke(LoanDetailsScreenEvent.OnCreateAccount(createAccountData))
+        },
+        accounts = state.accounts,
+        onPerformCalculations = {
+            onEventHandler.invoke(LoanModalEvent.PerformCalculation)
+        },
+        dateTime = state.dateTime,
         onSetDate = {
             onEventHandler.invoke(LoanModalEvent.OnChangeDate)
         },
@@ -223,17 +230,23 @@ private fun BoxWithConstraintsScope.UI(
     )
 
     LoanRecordModal(
-        modal = state.loanRecordModalData, onCreate = {
-        onEventHandler.invoke(LoanRecordModalEvent.OnCreateLoanRecord(it))
-    }, onEdit = {
-        onEventHandler.invoke(LoanRecordModalEvent.OnEditLoanRecord(it))
-    }, onDelete = { loanRecord ->
-        onEventHandler.invoke(LoanRecordModalEvent.OnDeleteLoanRecord(loanRecord))
-    }, accounts = state.accounts, dismiss = {
-        onEventHandler.invoke(LoanRecordModalEvent.OnDismissLoanRecord)
-    }, onCreateAccount = { createAccountData ->
-        onEventHandler.invoke(LoanDetailsScreenEvent.OnCreateAccount(createAccountData))
-    },
+        modal = state.loanRecordModalData,
+        onCreate = {
+            onEventHandler.invoke(LoanRecordModalEvent.OnCreateLoanRecord(it))
+        },
+        onEdit = {
+            onEventHandler.invoke(LoanRecordModalEvent.OnEditLoanRecord(it))
+        },
+        onDelete = { loanRecord ->
+            onEventHandler.invoke(LoanRecordModalEvent.OnDeleteLoanRecord(loanRecord))
+        },
+        accounts = state.accounts,
+        dismiss = {
+            onEventHandler.invoke(LoanRecordModalEvent.OnDismissLoanRecord)
+        },
+        onCreateAccount = { createAccountData ->
+            onEventHandler.invoke(LoanDetailsScreenEvent.OnCreateAccount(createAccountData))
+        },
         dateTime = state.dateTime,
         onSetDate = {
             onEventHandler.invoke(LoanRecordModalEvent.OnChangeDate)
@@ -273,7 +286,7 @@ private fun Header(
     onDeleteLoan: () -> Unit,
     loanAmountPaid: Double = 0.0,
     selectedLoanAccount: Account? = null,
-    onAddRecord: () -> Unit
+    onAddRecord: () -> Unit,
 ) {
     val contrastColor = findContrastTextColor(itemColor)
 
@@ -398,7 +411,7 @@ private fun LoanInfoCard(
     loanAmountPaid: Double = 0.0,
     selectedLoanAccount: Account? = null,
 
-    onAddRecord: () -> Unit
+    onAddRecord: () -> Unit,
 ) {
     val backgroundColor = if (isDarkColor(loan.color)) {
         MediumBlack.copy(alpha = 0.9f)
@@ -620,7 +633,7 @@ private fun LoanInfoCard(
 fun LazyListScope.loanRecords(
     loan: Loan,
     displayLoanRecords: List<DisplayLoanRecord> = emptyList(),
-    onClick: (DisplayLoanRecord) -> Unit
+    onClick: (DisplayLoanRecord) -> Unit,
 ) {
     items(items = displayLoanRecords) { displayLoanRecord ->
         LoanRecordItem(
@@ -644,7 +657,7 @@ private fun LoanRecordItem(
     baseCurrency: String,
     loanBaseCurrency: String = "",
     account: Account? = null,
-    onClick: () -> Unit
+    onClick: () -> Unit,
 ) {
     val nav = navigation()
     Column(
@@ -890,6 +903,7 @@ private fun NoLoanRecordsEmptyState() {
     }
 }
 
+@Suppress("UnusedPrivateMember")
 @IvyPreviews
 @Composable
 private fun Preview_Empty() {

screen/onboarding/src/main/java/com/ivy/onboarding/steps/OnboardingCategories.kt

@@ -32,7 +32,6 @@ import androidx.compose.ui.graphics.toArgb
 import androidx.compose.ui.res.painterResource
 import androidx.compose.ui.res.stringResource
 import androidx.compose.ui.text.font.FontWeight
-import androidx.compose.ui.tooling.preview.Preview
 import androidx.compose.ui.unit.dp
 import com.ivy.base.legacy.Theme
 import com.ivy.data.model.Category

screen/onboarding/src/main/java/com/ivy/onboarding/steps/OnboardingSetCurrency.kt

@@ -19,7 +19,6 @@ import androidx.compose.ui.Alignment
 import androidx.compose.ui.Modifier
 import androidx.compose.ui.res.stringResource
 import androidx.compose.ui.text.font.FontWeight
-import androidx.compose.ui.tooling.preview.Preview
 import androidx.compose.ui.unit.dp
 import com.ivy.base.legacy.Theme
 import com.ivy.design.l0_system.UI

screen/planned-payments/src/main/java/com/ivy/planned/edit/EditPlannedScreen.kt

@@ -22,21 +22,20 @@ import androidx.compose.ui.graphics.toArgb
 import androidx.compose.ui.platform.testTag
 import androidx.compose.ui.res.stringResource
 import androidx.compose.ui.text.input.TextFieldValue
-import androidx.compose.ui.tooling.preview.Preview
 import androidx.compose.ui.unit.dp
 import com.ivy.base.legacy.Theme
 import com.ivy.base.model.TransactionType
 import com.ivy.data.model.Category
 import com.ivy.data.model.IntervalType
 import com.ivy.legacy.IvyWalletPreview
 import com.ivy.legacy.datamodel.Account
+import com.ivy.legacy.ui.component.edit.core.Description
 import com.ivy.legacy.utils.onScreenStart
 import com.ivy.navigation.EditPlannedScreen
 import com.ivy.navigation.screenScopedViewModel
 import com.ivy.ui.R
-import com.ivy.wallet.ui.edit.core.Category
-import com.ivy.legacy.ui.component.edit.core.Description
 import com.ivy.ui.annotation.IvyPreviews
+import com.ivy.wallet.ui.edit.core.Category
 import com.ivy.wallet.ui.edit.core.EditBottomSheet
 import com.ivy.wallet.ui.edit.core.Title
 import com.ivy.wallet.ui.edit.core.Toolbar

screen/planned-payments/src/main/java/com/ivy/planned/list/PlannedPaymentsScreen.kt

@@ -10,7 +10,6 @@ import androidx.compose.ui.Modifier
 import androidx.compose.ui.graphics.toArgb
 import androidx.compose.ui.res.stringResource
 import androidx.compose.ui.text.font.FontWeight
-import androidx.compose.ui.tooling.preview.Preview
 import androidx.compose.ui.unit.dp
 import com.ivy.base.legacy.Theme
 import com.ivy.base.model.TransactionType
@@ -25,7 +24,6 @@ import com.ivy.design.l0_system.style
 import com.ivy.legacy.IvyWalletPreview
 import com.ivy.legacy.datamodel.Account
 import com.ivy.legacy.datamodel.PlannedPaymentRule
-import com.ivy.legacy.utils.timeNowUTC
 import com.ivy.navigation.EditPlannedScreen
 import com.ivy.navigation.PlannedPaymentsScreen
 import com.ivy.navigation.navigation
@@ -37,7 +35,6 @@ import com.ivy.wallet.ui.theme.Green
 import com.ivy.wallet.ui.theme.Orange
 import kotlinx.collections.immutable.persistentListOf
 import java.time.Instant
-import java.time.ZoneOffset
 import java.util.UUID
 
 @Composable

screen/reports/src/main/java/com/ivy/reports/ReportScreen.kt

@@ -86,6 +86,7 @@ fun BoxWithConstraintsScope.ReportScreen(
     )
 }
 
+@Suppress("LongMethod")
 @ExperimentalFoundationApi
 @Composable
 private fun BoxWithConstraintsScope.UI(

screen/settings/src/main/java/com/ivy/settings/SettingsScreen.kt

@@ -33,7 +33,6 @@ import androidx.compose.ui.platform.testTag
 import androidx.compose.ui.res.stringResource
 import androidx.compose.ui.text.font.FontWeight
 import androidx.compose.ui.text.style.TextAlign
-import androidx.compose.ui.tooling.preview.Preview
 import androidx.compose.ui.unit.Dp
 import androidx.compose.ui.unit.dp
 import androidx.compose.ui.unit.sp

screen/transactions/src/main/java/com/ivy/transactions/TransactionsScreen.kt

@@ -1,6 +1,5 @@
 package com.ivy.transactions
 
-import androidx.compose.foundation.ExperimentalFoundationApi
 import androidx.compose.foundation.background
 import androidx.compose.foundation.layout.Box
 import androidx.compose.foundation.layout.BoxWithConstraintsScope