This repository has been archived by the owner on Nov 5, 2024. It is now read-only.
Fix issue 2762 #2926
Merged
Fix issue 2762 #2926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # shared/data/src/main/java/com/ivy/data/repository/TransactionRepository.kt # shared/data/src/main/java/com/ivy/data/repository/impl/TransactionRepositoryImpl.kt # shared/data/src/main/java/com/ivy/data/source/LocalTransactionDataSource.kt
There was a problem hiding this comment.
Overall LGTM! A lof time has passed since we initially opened the data layer tasks and some things have changed. A few things to address:
- Fix all CI errors (most of them seem to be code formatting & styling)
- Remove the datasource + the fakes in :data-testing
- Fox inconsistencies in the mapper (https://github.com/Ivy-Apps/ivy-wallet/blob/data-layer-part-2/shared/data/src/main/java/com/ivy/data/repository/mapper/TransactionMapper.kt for reference)
Haven't reviewed fully but things seems good!
shared/data-testing/src/main/java/com/ivy/data/testing/FakeTransactionRepository.kt
Outdated
Show resolved
Hide resolved
shared/data/src/main/java/com/ivy/data/source/LocalTransactionDataSource.kt
Outdated
Show resolved
Hide resolved
shared/data/src/main/java/com/ivy/data/repository/mapper/TransactionMapper.kt
Outdated
Show resolved
Hide resolved
shared/data/src/main/java/com/ivy/data/repository/mapper/TransactionMapper.kt
Outdated
Show resolved
Hide resolved
shared/data-testing/src/test/java/com/ivy/data/testing/FakeTransactionRepositoryTest.kt
Outdated
Show resolved
Hide resolved
|
@Rick-AB feel free to suppress the Detekt erros |
ILIYANGERMANOV
approved these changes
Feb 8, 2024
There was a problem hiding this comment.
Nice work! 💯 Thank you for making the changes @Rick-AB :) Merging after the CI is green ✅
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) Checklist
Please check if your pull request fulfills the following requirements:
mainbranch.What's changed?
Describe with a few bullets what's new:
Risk Factors
What may go wrong if we merge your PR?
In what cases your code won't work?
Does this PR closes any GitHub Issues?
Check Ivy Wallet Issues.
Troubleshooting CI failures ❌
GitHub Actions failing? Read our CI Troubleshooting guide.