This repository has been archived by the owner on Nov 5, 2024. It is now read-only.
Fix issue 2927 (Crash Issue) #2934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed issue 2927
Added required string parameter for different languages
Total Balance Excluded string addition in all languages with single string
Account Spacing and Balance Row Spacer changes
Account Tab crash issue resolved
|
Thank you for the quick fix @sandeepjak2007! Can you test if the app shows the real balance on the accounts tab? Add 100 USD in one of your accounts |
ILIYANGERMANOV
approved these changes
Feb 8, 2024
There was a problem hiding this comment.
Merging to hitfix the crash. @sandeepjak2007 the excluded balance isn't displayed correctly, I think you're reading some String UI state that can never be parsed to double
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) Checklist
Please check if your pull request fulfills the following requirements:
mainbranch.What's changed?
Crash Issue resolved
AccountRecord.webm
Does this PR close any GitHub Issues?
Check Ivy Wallet Issues.