Skip to content
This repository has been archived by the owner on Nov 5, 2024. It is now read-only.

Fix Issue #2927 #2935

Merged
merged 1 commit into from
Feb 9, 2024
Merged

Fix Issue #2927 #2935

merged 1 commit into from
Feb 9, 2024

Conversation

sandeepjak2007
Copy link
Contributor

@sandeepjak2007 sandeepjak2007 commented Feb 9, 2024

The excluded Amount issue in the Account tab is fixed

Pull Request (PR) Checklist

Please check if your pull request fulfills the following requirements:

  • The PR is submitted to the main branch.
  • I've read the Contribution Guidelines and my PR doesn't break the rules.
  • I've read the Architecture Guidelines.
  • I confirm that I've run the code locally and everything works as expected.
  • 🎬 I've attached a screen recoding of the changes.

Tip: drag & drop the video to the PR description.

What's changed?

TBe-1
TBe

Check Ivy Wallet Issues.

Troubleshooting CI failures ❌

GitHub Actions failing? Read our CI Troubleshooting guide.

Excluded Amount issue in Account tab is fixed
Copy link
Collaborator

@ILIYANGERMANOV ILIYANGERMANOV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch @sandeepjak2007 💯 Thanks for the fix! Merging it after the CI pass

@ILIYANGERMANOV ILIYANGERMANOV merged commit 727031e into Ivy-Apps:main Feb 9, 2024
8 checks passed
@nvllz
Copy link
Contributor

nvllz commented Feb 9, 2024

Hi @sandeepjak2007, the Reorder button is now missing in the Accounts tab. Is this intentional?

@ILIYANGERMANOV
Copy link
Collaborator

Hi @sandeepjak2007, the Reorder button is now missing in the Accounts tab. Is this intentional?

That's definitely a regression! Good catch @nvllz 👏 We need #2923 asap

@sandeepjak2007
Copy link
Contributor Author

Hi @sandeepjak2007, the Reorder button is now missing in the Accounts tab. Is this intentional?

Could this issue be related to my commit? I've noticed no changes to the reorder button. If you come across any discrepancies, could you please post or highlight the specific commit that might have caused the problem?

@ILIYANGERMANOV
Copy link
Collaborator

Hi @sandeepjak2007, the Reorder button is now missing in the Accounts tab. Is this intentional?

Could this issue be related to my commit? I've noticed no changes to the reorder button. If you come across any discrepancies, could you please post or highlight the specific commit that might have caused the problem?

I think it happened when you update the UI in your first PR but I haven't double checked

@sandeepjak2007
Copy link
Contributor Author

Hi @sandeepjak2007, the Reorder button is now missing in the Accounts tab. Is this intentional?

Could this issue be related to my commit? I've noticed no changes to the reorder button. If you come across any discrepancies, could you please post or highlight the specific commit that might have caused the problem?

It's my fault only. Raising the PR with required screen shot

@ILIYANGERMANOV
Copy link
Collaborator

Or maybe not, it's probably some simple fix - for some reaso the button disappeared. Might be before your PRs, too

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Balance row text alignment
3 participants