This repository has been archived by the owner on Nov 5, 2024. It is now read-only.
Fix-Issue-2939 #2943
Merged
Fix-Issue-2939 #2943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implemented getSettingsWithNextTheme function in SettingsAct. Thanks to this change, codebase is a bit more DRY. - Refactored SettingsViewModel and HomeViewModel to use this function when changing the theme. - Changed `theme` in HomeViewModel to `currentTheme` to ensure consistency of naming in SettingsViewModel and HomeViewModel.
michalguspiel
commented
Feb 10, 2024
temp/legacy-code/src/main/java/com/ivy/legacy/domain/action/settings/SettingsAct.kt
Show resolved
Hide resolved
ILIYANGERMANOV
approved these changes
Feb 11, 2024
temp/legacy-code/src/main/java/com/ivy/legacy/domain/action/settings/SettingsAct.kt
Show resolved
Hide resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) Checklist
Please check if your pull request fulfills the following requirements:
mainbranch.What's changed?
themein HomeViewModel tocurrentThemeto ensure consistency of naming in SettingsViewModel and HomeViewModelScreen.Recording.2024-02-10.at.20.26.47.mov
Risk Factors
Does this PR closes any GitHub Issues?
Troubleshooting CI failures ❌
GitHub Actions failing? Read our CI Troubleshooting guide.