Skip to content
This repository has been archived by the owner on Nov 5, 2024. It is now read-only.

fix-issue-2940 #2953

Merged
merged 2 commits into from
Feb 12, 2024
Merged

fix-issue-2940 #2953

merged 2 commits into from
Feb 12, 2024

Conversation

madhavbhavsar
Copy link
Contributor

@madhavbhavsar madhavbhavsar commented Feb 12, 2024

Pull Request (PR) Checklist

Please check if your pull request fulfills the following requirements:

  • The PR is submitted to the main branch.
  • I've read the Contribution Guidelines and my PR doesn't break the rules.
  • I've read the Architecture Guidelines.
  • I confirm that I've run the code locally and everything works as expected.
  • 🎬 I've attached a screen recoding of the changes.

Tip: drag & drop the video to the PR description.

What's changed?

While sorting with balance amount the negative and positive balance are sorted with absolute value. So, I changed it with normal sorting and all the balance with 0 value are appended to the end.

Before After
image1 image2
-->
Before

before

After

Screenshot_1707738922

after
Screenshot_1707737029

Describe with a few bullets what's new:

  • remove .absoluteValue and added partition to add all 0 value balance in the end.

Risk Factors

No risk factors.

Does this PR closes any GitHub Issues?

Check Ivy Wallet Issues.

Replace ISSUE_NUMBER with the number of the GitHub issue that this PR is fixing. If you've done that correctly, you'll see the issue title linked when previewing your PR description.

!Note: Do not link the PR number. Link the number/id of the GitHub Issue from issues.

Troubleshooting CI failures ❌

GitHub Actions failing? Read our CI Troubleshooting guide.

@ILIYANGERMANOV
Copy link
Collaborator

/home/runner/work/ivy-wallet/ivy-wallet/screen/categories/src/main/java/com/ivy/categories/CategoriesViewModel.kt:33:1: Unused import [NoUnusedImports]

@madhavbhavsar
Copy link
Contributor Author

oh ,sorry i forgot again, should i PR again?

@ILIYANGERMANOV
Copy link
Collaborator

oh ,sorry i forgot again, should i PR again?

just push new commits in your branch that fix the Detekt error, the PR will update automatically

@ILIYANGERMANOV ILIYANGERMANOV merged commit 788738d into Ivy-Apps:main Feb 12, 2024
8 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Sorting categories by balance amount works incorrectly
2 participants