Skip to content
This repository has been archived by the owner on Nov 5, 2024. It is now read-only.

Fix issue 2931 #2955

Merged
merged 2 commits into from
Feb 12, 2024
Merged

Fix issue 2931 #2955

merged 2 commits into from
Feb 12, 2024

Conversation

Rick-AB
Copy link
Contributor

@Rick-AB Rick-AB commented Feb 12, 2024

Pull Request (PR) Checklist

Please check if your pull request fulfills the following requirements:

  • The PR is submitted to the main branch.
  • I've read the Contribution Guidelines and my PR doesn't break the rules.
  • I've read the Architecture Guidelines.
  • I confirm that I've run the code locally and everything works as expected.
  • 🎬 I've attached a screen recoding of the changes.

Tip: drag & drop the video to the PR description.

What's changed?

Describe with a few bullets what's new:

  • updated few function in fake account dao
  • implemented tests for fake account dao

💡 Tip: Please, attach screenshots and screen recordings. It helps a lot!

Risk Factors

What may go wrong if we merge your PR?

  • N/A

In what cases your code won't work?

  • N/A

Does this PR closes any GitHub Issues?

Check Ivy Wallet Issues.

Replace ISSUE_NUMBER with the number of the GitHub issue that this PR is fixing. If you've done that correctly, you'll see the issue title linked when previewing your PR description.

!Note: Do not link the PR number. Link the number/id of the GitHub Issue from issues.

Troubleshooting CI failures ❌

GitHub Actions failing? Read our CI Troubleshooting guide.

Copy link
Collaborator

@ILIYANGERMANOV ILIYANGERMANOV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 💯

@ILIYANGERMANOV ILIYANGERMANOV merged commit fd178c9 into Ivy-Apps:main Feb 12, 2024
8 checks passed
@ILIYANGERMANOV
Copy link
Collaborator

no payment

________________________________ จาก: Chomsin Mahiranyawong ส่ง: 13 กุมภาพันธ์ 2567 5:19 ถึง: Iliyan Germanov @.>; Ivy-Apps/ivy-wallet @.>; Ivy-Apps/ivy-wallet @.> สำเนาถึง: Subscribed @.> ชื่อเรื่อง: Re: [Ivy-Apps/ivy-wallet] Fix issue 2931 (PR #2955) No
________________________________ จาก: Iliyan Germanov @.> ส่ง: 13 กุมภาพันธ์ 2567 5:08 ถึง: Ivy-Apps/ivy-wallet @.> สำเนาถึง: Subscribed @.> ชื่อเรื่อง: Re: [Ivy-Apps/ivy-wallet] Fix issue 2931 (PR #2955) @ILIYANGERMANOV approved this pull request. Nice 💯 — Reply to this email directly, view it on GitHub<#2955 (review)>, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BAJPR7OMJWIVVP6QQFYPMYTYTKHFNAVCNFSM6AAAAABDFOZAKWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQNZWGQ2DCNRQHA. You are receiving this because you are subscribed to this thread.Message ID: @.>

Hey @chomsin I don't quite get that. What payment?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement the FakeAccountDao
2 participants