Skip to content
This repository has been archived by the owner on Nov 5, 2024. It is now read-only.

fixed issue 2938 #2976

Closed
wants to merge 2 commits into from
Closed

fixed issue 2938 #2976

wants to merge 2 commits into from

Conversation

madhavbhavsar
Copy link
Contributor

@madhavbhavsar madhavbhavsar commented Feb 20, 2024

Pull Request (PR) Checklist

Please check if your pull request fulfills the following requirements:

  • The PR is submitted to the main branch.
  • I've read the Contribution Guidelines and my PR doesn't break the rules.
  • I've read the Architecture Guidelines.
  • I confirm that I've run the code locally and everything works as expected.
  • 🎬 I've attached a screen recoding of the changes.

Tip: drag & drop the video to the PR description.

What's changed?

2938.mp4

Describe with a few bullets what's new:

  • a - Added rememberScrollPositionListState imported from shared.CommonUi package, and added listState variable in context to save the scroll position.

💡 Tip: Please, attach screenshots and screen recordings. It helps a lot!

Risk Factors

No Risk Factors.

Does this PR closes any GitHub Issues?

Check Ivy Wallet Issues.

Replace ISSUE_NUMBER with the number of the GitHub issue that this PR is fixing. If you've done that correctly, you'll see the issue title linked when previewing your PR description.

!Note: Do not link the PR number. Link the number/id of the GitHub Issue from issues.

Troubleshooting CI failures ❌

GitHub Actions failing? Read our CI Troubleshooting guide.

@madhavbhavsar madhavbhavsar deleted the fix_issue_2938 branch February 20, 2024 09:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Remembering the scroll position for Accounts and Categories screens
1 participant