Fix URL params decoding (#62)

* Fix missing URL decoding * Improve analytics logging
Ivy-Apps · Dec 4, 2024 · 2dcfd03 · 2dcfd03
1 parent df5a289
commit 2dcfd03
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/composeApp/src/commonMain/kotlin/domain/analytics/Analytics.kt b/composeApp/src/commonMain/kotlin/domain/analytics/Analytics.kt
@@ -45,7 +45,7 @@ class Analytics(
         appScope.launch {
             // TODO: Optimize later by batching events
             val paramsJson = Json.encodeToString(params)
-            logger.info("$TAG Tracking: '$eventName' with $paramsJson params...")
+            logger.info("$TAG Tracking: '$eventName' with $paramsJson params.")
             analyticsRepository.logEvent(
                 setOf(
                     AnalyticsEventDto(

diff --git a/composeApp/src/jsMain/kotlin/navigation/SystemNavigation.js.kt b/composeApp/src/jsMain/kotlin/navigation/SystemNavigation.js.kt
@@ -67,10 +67,18 @@ class WebSystemNavigation : SystemNavigation {
             .split("&")
             .mapNotNull {
                 val parts = it.split("=")
-                if (parts.size == 2) parts[0] to parts[1] else null
+                if (parts.size == 2) {
+                    val key = decodeURIComponent(parts[0])
+                    val value = decodeURIComponent(parts[1])
+                    key to value
+                } else null
             }
             .toMap()
     }
+
+    private fun decodeURIComponent(encoded: String): String {
+        return js("decodeURIComponent")(encoded) as String
+    }
 }