Revised determination of a next or previous visible node (at "v7") #1279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 29, 2024 15:47
- added method 'TBaseVirtualTree.GetTopInvisibleParent' to retrieve the topmost node of an effectively invisible subtree - the resulting node can be invisible by lacking the 'vsVisible'-flag on its own or having its parent lacking the 'vsExpanded' flag - all of its sub-nodes can be considered effectively invisible - all of its ancestor-nodes can be considered to be effectively visible - 'nil' is returned if all nodes from 'Node' up to 'FRoot' are effectively visible
…it]' completely to ensure a node cannot be returned as its own next or previous node - updated methods 'TBaseVirtualTree.GetNextVisible' and 'TBaseVirtualTree.GetNextVisibleNoInit' as well as 'TBaseVirtualTree.GetPreviousVisible' and 'TBaseVirtualTree.GetPreviousVisibleNoInit' to harmonize the determination of a next or previous visible node - used method 'TBaseVirtualTree.GetTopInvisibleParent' to optimize the search by skipping effectively non-visible subtrees as a whole independent from 'ChildrenAbove' mode - applied the condition to force searching for another node from 'TBaseVirtualTree.GetNextVisible' and 'TBaseVirtualTree.GetNextVisibleNoInit' to 'TBaseVirtualTree.GetPreviousVisible' and 'TBaseVirtualTree.GetPreviousVisibleNoInit' - extended that condition to force searching for another node when the current node is known to be in an effectively non-visible subtree - thus, the input node cannot be returned as its own next/previous visible node, which is ensured with an assertion at the end of each method - note that the usage of other methods obscuring the traversal algorithm, such as 'GetVisibleParent', 'GetFirstVisible', 'GetLastVisible', 'GetPreviousSibling', etc. is avoided
hermannoffen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #1278. See also PR #1280.