add default value for need_destroy

JDRaftKeeper · Dec 11, 2023 · 130daf6 · 130daf6
1 parent 0e7a657
commit 130daf6
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 5 deletions.
diff --git a/src/Service/ForwardingConnectionHandler.cpp b/src/Service/ForwardingConnectionHandler.cpp
@@ -102,6 +102,10 @@ void ForwardingConnectionHandler::onSocketReadable(const AutoPtr<ReadableNotific
                     case ForwardType::Operation:
                         current_package.is_done = false;
                         break;
+                    case ForwardType::Destroy:
+                        LOG_WARNING(log, "Got destroy forward package type {}", forward_type);
+                        destroyMe();
+                        return;
                     default:
                         LOG_ERROR(log, "Got unexpected forward package type {}", forward_type);
                         destroyMe();
@@ -294,9 +298,9 @@ void ForwardingConnectionHandler::onSocketWritable(const AutoPtr<WritableNotific
 
     try
     {
-        if (is_destroy)
+        if (need_destroy)
         {
-            LOG_INFO(log, "Get destroy response!");
+            LOG_WARNING(log, "The connection for server {} client {} is stale, will close it", server_id, client_id);
             delete this;
             return;
         }
@@ -382,7 +386,7 @@ void ForwardingConnectionHandler::sendResponse(ForwardResponsePtr response)
 
     if (response->forwardType() == ForwardType::Destroy)
     {
-        is_destroy = true;
+        need_destroy = true;
     }
 
     WriteBufferFromFiFoBuffer buf;

diff --git a/src/Service/ForwardingConnectionHandler.h b/src/Service/ForwardingConnectionHandler.h
@@ -91,8 +91,8 @@ class ForwardingConnectionHandler
     void processRaftRequest(ForwardRequestPtr request);
     void processSessions(ForwardRequestPtr request);
 
-    // mark is stop by dispatcher
-    bool is_destroy;
+    // The connection is stale and need destroyed
+    bool need_destroy{false};
 };
 
 }