Make different internal id for different nodes

src/Service/KeeperDispatcher.h

@@ -126,6 +126,7 @@ class KeeperDispatcher : public std::enable_shared_from_this<KeeperDispatcher>
     /// Push forwarding request
     bool pushForwardingRequest(size_t server_id, size_t client_id, ForwardRequestPtr request);
 
+    /// TODO remove
     int64_t newSession(int64_t session_timeout_ms) { return server->newSession(session_timeout_ms); }
     bool updateSessionTimeout(int64_t session_id, int64_t session_timeout_ms)
     {
@@ -222,7 +223,11 @@ class KeeperDispatcher : public std::enable_shared_from_this<KeeperDispatcher>
     int32_t myId() const { return server->myId(); }
 
     /// When user create new session, we use this id as request id.
-    int64_t getNewSessionInternalId() { return new_session_internal_id_counter++; }
+    /// Note that the internal id for different nodes can be same.
+    int64_t getNewSessionInternalId() {
+        auto increment = myId() + 1; /// In case of my_id is 0
+        return new_session_internal_id_counter.fetch_add(increment) + increment;
+    }
 };
 
 }

src/Service/Settings.h

@@ -33,23 +33,23 @@ using RaftSettingsPtr = std::shared_ptr<RaftSettings>;
 
 struct Settings
 {
-    static constexpr int NOT_EXIST = -1;
+    static constexpr int32_t NOT_EXIST = -1;
     static const String DEFAULT_FOUR_LETTER_WORD_CMD;
 
     Settings();
-    int my_id;
+    uint32_t my_id;
 
     String host;
-    int port;
+    int32_t port;
 
     // TODO add forwarding_port
-    int internal_port;
+    int32_t internal_port;
 
     String log_dir;
     String snapshot_dir;
 
-    int snapshot_create_interval;
-    int thread_count;
+    int32_t snapshot_create_interval;
+    int32_t thread_count;
 
     String four_letter_word_white_list;