Avoid memory copy when parsing log #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lzydmxy
reviewed
Feb 27, 2024
| @@ -572,7 +572,8 @@ int NuRaftLogSegment::loadLogEntry(int fd, off_t offset, LogEntryHeader * head, | |||
| return -1; | |||
| } | |||
|
|
|||
| entry = LogEntryBody::parse(entry_str, head->term, head->data_length); | |||
| entry = LogEntryBody::parse(entry_str, head->data_length); | |||
| entry->set_term(head->term); | |||
|
|
|||
| delete[] entry_str; | |||
There was a problem hiding this comment.
why not use buffer for entry_str instead of char pointer to avoid copy and delete.
There was a problem hiding this comment.
Because when we serialize data there is no header of buffer and this copy can not be avoided
There was a problem hiding this comment.
Got it, maybe better to use buffer to avoid manual memory release.
There was a problem hiding this comment.
No need to worry about memory deallocation issues for the method is only invoked synchronously.
There was a problem hiding this comment.
But I think we should not use raw pointer in NuRaftLogSegment.cpp, maybe fixed in another PR.
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issues of this PR fixes:
This PR try to fix #199
Change log: