Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forwarding error may cause request not found in request processor pending queue #208

Merged
merged 1 commit into from
Feb 29, 2024
Merged

Forwarding error may cause request not found in request processor pending queue #208

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/Service/RequestProcessor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,8 +137,8 @@ bool RequestProcessor::shouldProcessCommittedRequest(const RequestForSession & c
found_in_pending_queue = false;
LOG_WARNING(
this->log,
"Not found committed(write) request {} in pending queue. Possible reason: 1.close requests from deadSessionCleanThread are not put "
"into pending queue; 2.error occurs(because of forward or append entries) but request is still committed, "
"Not found committed(write) request {} in pending queue. Possible reason: 1.close requests from deadSessionCleanThread are not "
"put into pending queue; 2.error occurs(because of forward or append entries) but request is still committed, "
"'processErrorRequest' may delete request from pending request first, so here we can not find it.",
committed_request.toSimpleString());
};
Expand Down Expand Up @@ -349,10 +349,10 @@ void RequestProcessor::processErrorRequest(size_t count)
{
LOG_WARNING(
this->log,
"Not found error request {} in pending queue. Possible reason: 1.close requests from deadSessionCleanThread are not put "
"into pending queue; 2.error occurs(forward or append entries) but request is still committed, "
"'processCommittedRequest' may delete request from pending request first, so here we can not find it. We also delete "
"it from errors.",
"Not found error request {} in pending queue. Possible reason: 1. request forwarding error; 2.close requests from "
"deadSessionCleanThread are not put into pending queue; 3.error occurs(forward or append entries) but request is still "
"committed, 'processCommittedRequest' may delete request from pending request first, so here we can not find it. We "
"also delete it from errors.",
error_request.toString());

error_request_ids.erase(error_request.getRequestId());
Expand Down
Loading