-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement asynchronous snapshot by copying dataTree #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JackyWoo
reviewed
May 7, 2024
@lzydmxy nice work, please show us the memory usage when creating snapshot. |
I will carefully review this PR tomorrow. |
JackyWoo
reviewed
May 7, 2024
JackyWoo
reviewed
May 8, 2024
@lzydmxy LGTM except some code sytle issues. |
JackyWoo
approved these changes
May 8, 2024
This was referenced May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issues of this PR fixes:
This PR is part of #144
Change log:
Motivation:
Right now keeper creates snapshot synchronously, during which period, it is unable to handle to user requests for creating snapshot is in the request handling procress.
If a cluser has large amount of data, creating snapshot will lead large blocking time. And because keeper can not handle heartbeat, leader election may happen. Both of them will make keeper unavailable.
Solution:
The main idea is a little like COW.
Optimization result:
We have a keeper cluster which holds metadata of Clickhouse and it has 58659723 nodes.