Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fail fast for log error #340

Merged
merged 4 commits into from
Aug 19, 2024
Merged

Fail fast for log error #340

merged 4 commits into from
Aug 19, 2024

Conversation

JackyWoo
Copy link
Contributor

@JackyWoo JackyWoo commented Aug 9, 2024 •
edited
Loading

Which issues of this PR fixes:

This PR try to fix #321

Change log:

  1. Fail fast for log error
  2. Some refactoring
  3. Add crc info when cloning log entry

@JackyWoo JackyWoo added the bug Something isn't working label Aug 9, 2024
@JackyWoo JackyWoo added this to the Release v2.2.0 milestone Aug 9, 2024
@JackyWoo
Copy link
Contributor Author

JackyWoo commented Aug 9, 2024 •
edited
Loading

@lzydmxy please take a look

@lzydmxy
Copy link
Contributor

lzydmxy commented Aug 19, 2024

LGTM

@JackyWoo JackyWoo merged commit 25857d3 into JDRaftKeeper:master Aug 19, 2024
7 checks passed
@JackyWoo JackyWoo mentioned this pull request Sep 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lzydmxy lzydmxy lzydmxy left review comments

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
Release v2.2.0
Development

Successfully merging this pull request may close these issues.

Exit when encountering an error while persisting the log to disk
2 participants
@JackyWoo @lzydmxy