Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multi-read requests #94

Merged
merged 4 commits into from
Oct 23, 2023
Merged

Conversation

lzydmxy
Copy link
Contributor

@lzydmxy lzydmxy commented Oct 18, 2023

Which issues of this PR fixes:

This PR try to close #86

Change log:

  • Support multi-read ops
  • remove stat in simple-list response

@JackyWoo JackyWoo added this to the Release v2.0.3 milestone Oct 18, 2023
@JackyWoo JackyWoo added the feature New feature or request label Oct 18, 2023
@JackyWoo JackyWoo self-assigned this Oct 18, 2023
src/Service/KeeperStore.cpp Show resolved Hide resolved
src/ZooKeeper/ZooKeeperCommon.cpp Outdated Show resolved Hide resolved
src/ZooKeeper/ZooKeeperCommon.h Outdated Show resolved Hide resolved
src/ZooKeeper/ZooKeeperCommon.h Show resolved Hide resolved
src/ZooKeeper/ZooKeeperCommon.h Show resolved Hide resolved
tests/integration/helpers/utils.py Show resolved Hide resolved
tests/integration/test_back_to_back/test.py Outdated Show resolved Hide resolved
tests/integration/test_back_to_back/test.py Outdated Show resolved Hide resolved
@JackyWoo
Copy link
Contributor

@lzydmxy please rebase the master into your branch.

@lzydmxy
Copy link
Contributor Author

lzydmxy commented Oct 20, 2023

@lzydmxy please rebase the master into your branch.

okay~

@JackyWoo JackyWoo merged commit bba96f4 into JDRaftKeeper:master Oct 23, 2023
6 checks passed
@lzydmxy
Copy link
Contributor Author

lzydmxy commented Nov 13, 2023

MuiltReadReponse for ClickHouse Keeper a little different from ZK.
In error handle, for example, get a node does not exist.
for ZK

MultiHeader(type=-1, done=False, err=-101), body='-101'

for ClickHouse Keeper

MultiHeader(type=8, done=False, err=-101)

Zk comes with an extra body (int) to indicate errors, error code is duplicated in header and in response body, and set ops_type to -1 for err.
But ClickHouse Keeper move body, and remain ops_type unchanged.

@JackyWoo Should we keeper zookeeper style, or change to ClickHouse Keeper?

@JackyWoo
Copy link
Contributor

Can CK be compatible with the handling approach of ZK?

@lzydmxy
Copy link
Contributor Author

lzydmxy commented Nov 14, 2023

Can CK be compatible with the handling approach of ZK?

Yes, CK is compatible with the handling approach of ZK. This is just an optional optimization.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support multi-read requests.
2 participants