Use the configured streams on JRuby with JLine #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this commit, the input and output parameters to HighLine.new were ignored for #ask (both for specifying the input stream and for displaying the prompt). This commit fixes issue JEG2#31, which was introduced by PR JEG2#27. Since then, the HighLine tests have been unable to run on JRuby. With this change, the tests run on JRuby 1.7.3 but many of them fail. No tests fail on JRuby 1.7.3 using the version of HighLine from immediately before JEG2#27 was merged, so it seems likely the failures were caused by JEG2#27 also. This commit stops using `SystemExtensions#initialize` to set up JLine. It would have been possible to pass the input and output parameters to the `super` call, but that seemed to me like an abuse of inheritance. Instead, following the pattern of the rest of SystemExtensions, I added a method called `initialize_system_extensions` which is defined on a per-platform basis (currently for JRuby only) and invoked by `HighLine#initialize` when present.
This was referenced Feb 23, 2013
JEG2
added a commit
that referenced
this pull request
Feb 23, 2013
Use the configured streams on JRuby with JLine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this change, the input and output parameters to
HighLine.neware ignored for#ask(both for specifying the input stream and for displaying the prompt).This addresses issue #31, though not completely — while it allows the tests to run on JRuby, many of them fail.
With this patch applied, the tests run to completion on JRuby 1.7.3:
On JRuby 1.6.8, they get further than they do without the patch, but many of them error out (as opposed to failing). The test run slows and eventually hangs before completing. The problem on 1.6.8 seems to be that the runner is running out of heap space.
For both JRuby 1.7.3 and 1.6.8, though, HighLine does better with this patch than without it so I'm submitting it for review.