Skip to content

Commit

Permalink
don't use keyword args to calc_footprint (for JS compat)
Browse files Browse the repository at this point in the history
keyword arguments only work properly in Transcrypt if we have the `__kwargs__` pragma enabled on the funtion that accepts them. Since we are giving all the arguments here, it's easy enough to just pass them as positional arguments, eliminating the need for keyword arguments here
  • Loading branch information
JGreenlee committed Oct 23, 2024
1 parent f061208 commit 1809ce3
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions src/emcommon/metrics/footprint/footprint_calculations.py
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,10 @@ async def calc_footprint_for_trip(trip, label_options, mode_key='mode', mode_val
trip['distance'],
emcmfu.year_of_trip(trip),
trip['start_loc']['coordinates'],
uace=trip.get('uace_region'),
egrid_region=trip.get('egrid_region'),
passengers=rich_mode.get('passengers', 1),
metadata={'trip_id': trip['_id']}
trip.get('uace_region'),
trip.get('egrid_region'),
rich_mode.get('passengers', 1),
{'trip_id': trip['_id']}
)
# If is_uncertain, the kwh and kg_co2 values represent the upper bound (worst-case scenario)
# Mark them as them uncertain, then set the main values to 0 to represent the lower bound.
Expand Down

0 comments on commit 1809ce3

Please sign in to comment.