Feature/integration tests (#165)

* Fixed stats endpoints last stats by splitting endpoints * Add integration tests * Updated CryptoExchange.Net
JKorf · Jul 26, 2024 · 604072a · 604072a
1 parent 97f75cf
commit 604072a
Show file tree

Hide file tree

Showing 11 changed files with 393 additions and 55 deletions.
diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
@@ -0,0 +1,25 @@
+name: Integration Testing
+
+on:
+  schedule:
+    - cron: "0 0 * * *"
+
+jobs:
+  build:
+
+    runs-on: ubuntu-latest
+
+    steps:
+    - uses: actions/checkout@v2
+    - name: Setup .NET
+      uses: actions/setup-dotnet@v1
+      with:
+        dotnet-version: 6.0.x
+    - name: Set GitHub package source
+      run: dotnet nuget add source --username JKorf --password ${{ secrets.GITHUB_TOKEN }} --store-password-in-clear-text --name github "https://nuget.pkg.github.com/JKorf/index.json"
+    - name: Restore dependencies
+      run: dotnet restore
+    - name: Build
+      run: dotnet build --no-restore
+    - name: Test
+      run: dotnet test --no-build --verbosity normal -e INTEGRATION=1
diff --git a/Bitfinex.Net.UnitTests/BitfinexRestIntegrationTests.cs b/Bitfinex.Net.UnitTests/BitfinexRestIntegrationTests.cs
@@ -0,0 +1,125 @@
+using Bitfinex.Net;
+using Bitfinex.Net.Clients;
+using CryptoExchange.Net.Testing;
+using Microsoft.Extensions.Logging;
+using NUnit.Framework;
+using System;
+using System.Diagnostics;
+using System.Threading.Tasks;
+
+namespace Bitfinex.Net.UnitTests
+{
+    [NonParallelizable]
+    internal class BitfinexRestIntegrationTests : RestIntergrationTest<BitfinexRestClient>
+    {
+        public override bool Run { get; set; }
+
+        public BitfinexRestIntegrationTests()
+        {
+        }
+
+        public override BitfinexRestClient GetClient(ILoggerFactory loggerFactory)
+        {
+            var key = Environment.GetEnvironmentVariable("APIKEY");
+            var sec = Environment.GetEnvironmentVariable("APISECRET");
+
+            Authenticated = key != null && sec != null;
+            return new BitfinexRestClient(null, loggerFactory, opts =>
+            {
+                opts.OutputOriginalData = true;
+                opts.ApiCredentials = Authenticated ? new CryptoExchange.Net.Authentication.ApiCredentials(key, sec) : null;
+            });
+        }
+
+        [Test]
+        public async Task TestErrorResponseParsing()
+        {
+            if (!ShouldRun())
+                return;
+
+            var result = await CreateClient().SpotApi.ExchangeData.GetOrderBookAsync("TST-TST", default);
+
+            Assert.That(result.Success, Is.False);
+            Assert.That(result.Error.Code, Is.EqualTo(10020));
+        }
+
+        [Test]
+        public async Task TestSpotAccount()
+        {
+            await RunAndCheckResult(client => client.SpotApi.Account.GetBalancesAsync(default), true);
+            await RunAndCheckResult(client => client.SpotApi.Account.GetBaseMarginInfoAsync(default), true);
+            await RunAndCheckResult(client => client.SpotApi.Account.GetSymbolMarginInfoAsync("tETHUSD", default), true);
+            await RunAndCheckResult(client => client.SpotApi.Account.GetMovementsAsync(default, default, default, default, default, default, default), true);
+            await RunAndCheckResult(client => client.SpotApi.Account.GetAlertListAsync(default), true);
+            await RunAndCheckResult(client => client.SpotApi.Account.GetAvailableBalanceAsync("tETHUSD", Enums.OrderSide.Buy, 1000, Enums.WalletType.Exchange, default, default), true);
+            await RunAndCheckResult(client => client.SpotApi.Account.GetLedgerEntriesAsync(default, default, default, default, default, default), true);
+            await RunAndCheckResult(client => client.SpotApi.Account.GetUserInfoAsync(default), true);
+            await RunAndCheckResult(client => client.SpotApi.Account.Get30DaySummaryAndFeesAsync(default), true);
+            await RunAndCheckResult(client => client.SpotApi.Account.GetLoginHistoryAsync(default, default, default, default), true);
+            await RunAndCheckResult(client => client.SpotApi.Account.GetApiKeyPermissionsAsync(default), true);
+            await RunAndCheckResult(client => client.SpotApi.Account.GetAccountChangeLogAsync(default), true);
+        }
+
+        [Test]
+        public async Task TestSpotExchangeData()
+        {
+            await RunAndCheckResult(client => client.SpotApi.ExchangeData.GetPlatformStatusAsync(default), false);
+            await RunAndCheckResult(client => client.SpotApi.ExchangeData.GetAssetsListAsync(default), false);
+            await RunAndCheckResult(client => client.SpotApi.ExchangeData.GetSymbolNamesAsync(Enums.SymbolType.Exchange, default), false);
+            await RunAndCheckResult(client => client.SpotApi.ExchangeData.GetAssetNamesAsync(default), false);
+            await RunAndCheckResult(client => client.SpotApi.ExchangeData.GetAssetSymbolsAsync(default), false);
+            await RunAndCheckResult(client => client.SpotApi.ExchangeData.GetAssetFullNamesAsync(default), false);
+            await RunAndCheckResult(client => client.SpotApi.ExchangeData.GetAssetUnitsAsync(default), false);
+            await RunAndCheckResult(client => client.SpotApi.ExchangeData.GetAssetUnderlyingsAsync(default), false);
+            await RunAndCheckResult(client => client.SpotApi.ExchangeData.GetAssetNetworksAsync(default), false);
+            await RunAndCheckResult(client => client.SpotApi.ExchangeData.GetAssetBlockExplorerUrlsAsync(default), false);
+            await RunAndCheckResult(client => client.SpotApi.ExchangeData.GetAssetWithdrawalFeesAsync(default), false);
+            await RunAndCheckResult(client => client.SpotApi.ExchangeData.GetAssetDepositWithdrawalMethodsAsync(default), false);
+            await RunAndCheckResult(client => client.SpotApi.ExchangeData.GetSymbolsAsync(default), false);
+            await RunAndCheckResult(client => client.SpotApi.ExchangeData.GetFuturesSymbolsAsync(default), false);
+            await RunAndCheckResult(client => client.SpotApi.ExchangeData.GetDepositWithdrawalStatusAsync(default), false);
+            await RunAndCheckResult(client => client.SpotApi.ExchangeData.GetMarginInfoAsync(default), false);
+            await RunAndCheckResult(client => client.SpotApi.ExchangeData.GetDerivativesFeesAsync(default), false);
+            await RunAndCheckResult(client => client.SpotApi.ExchangeData.GetTickerAsync("tETHUST", default), false);
+            await RunAndCheckResult(client => client.SpotApi.ExchangeData.GetFundingTickerAsync("fUSD", default), false);
+            await RunAndCheckResult(client => client.SpotApi.ExchangeData.GetTickersAsync(default, default), false);
+            //await RunAndCheckResult(client => client.SpotApi.ExchangeData.GetFundingTickersAsync(default, default), false);
+            await RunAndCheckResult(client => client.SpotApi.ExchangeData.GetTickerHistoryAsync(default, default, default, default, default), false);
+            await RunAndCheckResult(client => client.SpotApi.ExchangeData.GetTradeHistoryAsync("tETHUST", default, default, default, default, default), false);
+            await RunAndCheckResult(client => client.SpotApi.ExchangeData.GetOrderBookAsync("tETHUST", Enums.Precision.PrecisionLevel2, default, default), false);
+            await RunAndCheckResult(client => client.SpotApi.ExchangeData.GetFundingOrderBookAsync("fUSD", Enums.Precision.PrecisionLevel2, default, default), false);
+            await RunAndCheckResult(client => client.SpotApi.ExchangeData.GetRawOrderBookAsync("fUSD", default, default), false);
+            await RunAndCheckResult(client => client.SpotApi.ExchangeData.GetRawFundingOrderBookAsync("fUSD", default, default), false);
+            await RunAndCheckResult(client => client.SpotApi.ExchangeData.GetLastKlineAsync("tETHUST", Enums.KlineInterval.OneDay, default, default), false);
+            await RunAndCheckResult(client => client.SpotApi.ExchangeData.GetKlinesAsync("tETHUST", Enums.KlineInterval.OneDay, default, default, default, default, default, default), false);
+            await RunAndCheckResult(client => client.SpotApi.ExchangeData.GetAveragePriceAsync("tETHUST", 1, default, default, default), false);
+            await RunAndCheckResult(client => client.SpotApi.ExchangeData.GetForeignExchangeRateAsync("BTC", "USD", default), false);
+            await RunAndCheckResult(client => client.SpotApi.ExchangeData.GetDerivativesStatusAsync(default, default), false);
+            await RunAndCheckResult(client => client.SpotApi.ExchangeData.GetDerivativesStatusHistoryAsync("tBTCF0:USTF0", default, default, default, default, default), false);
+            await RunAndCheckResult(client => client.SpotApi.ExchangeData.GetLiquidationsAsync(default, default, default, default, default), false);
+            await RunAndCheckResult(client => client.SpotApi.ExchangeData.GetFundingStatisticsAsync("fUSD", default, default, default, default), false);
+            await RunAndCheckResult(client => client.SpotApi.ExchangeData.GetLastFundingSizeAsync("fUSD", default), false);
+            await RunAndCheckResult(client => client.SpotApi.ExchangeData.GetFundingSizeHistoryAsync("fUSD", default, default, default, default, default), false);
+            await RunAndCheckResult(client => client.SpotApi.ExchangeData.GetLastCreditSizeAsync("fUSD", default), false);
+            await RunAndCheckResult(client => client.SpotApi.ExchangeData.GetCreditSizeHistoryAsync("fUSD", default, default, default, default, default), false);
+            await RunAndCheckResult(client => client.SpotApi.ExchangeData.GetLastLongsShortsTotalsAsync("tETHUSD", Enums.StatSide.Long, default), false);
+            await RunAndCheckResult(client => client.SpotApi.ExchangeData.GetLongsShortsTotalsHistoryAsync("tETHUSD", Enums.StatSide.Long, default, default, default, default, default), false);
+            await RunAndCheckResult(client => client.SpotApi.ExchangeData.GetLastTradingVolumeAsync(1, default), false);
+            await RunAndCheckResult(client => client.SpotApi.ExchangeData.GetTradingVolumeHistoryAsync(1, default, default, default, default, default), false);
+            await RunAndCheckResult(client => client.SpotApi.ExchangeData.GetLastVolumeWeightedAveragePriceAsync("tETHUSD", default), false);
+            await RunAndCheckResult(client => client.SpotApi.ExchangeData.GetVolumeWeightedAveragePriceHistoryAsync("tETHUSD", default, default, default, default, default), false);
+
+        }
+
+        [Test]
+        public async Task TestSpotTrading()
+        {
+            await RunAndCheckResult(client => client.SpotApi.Trading.GetOpenOrdersAsync(default, default, default), true);
+            await RunAndCheckResult(client => client.SpotApi.Trading.GetClosedOrdersAsync(default, default, default, default, default, default), true);
+            await RunAndCheckResult(client => client.SpotApi.Trading.GetUserTradesAsync(default, default, default, default, default), true);
+            await RunAndCheckResult(client => client.SpotApi.Trading.GetPositionHistoryAsync(default, default, default, default), true);
+            await RunAndCheckResult(client => client.SpotApi.Trading.GetPositionsAsync(default), true);
+            await RunAndCheckResult(client => client.SpotApi.Trading.GetPositionSnapshotsAsync(default, default, default, default), true);
+        }
+    }
+}
diff --git a/Bitfinex.Net.UnitTests/Endpoints/Spot/ExchangeData/GetCreditSize.txt b/Bitfinex.Net.UnitTests/Endpoints/Spot/ExchangeData/GetCreditSize.txt
@@ -1,5 +1,5 @@
 GET
-/v2/stats1/credits.size:1m:UST/last
+/v2/stats1/credits.size:1m:UST/hist
 false
 [
   [

diff --git a/Bitfinex.Net.UnitTests/Endpoints/Spot/ExchangeData/GetCreditSize2.txt b/Bitfinex.Net.UnitTests/Endpoints/Spot/ExchangeData/GetCreditSize2.txt
@@ -1,5 +1,5 @@
 GET
-/v2/stats1/credits.size.sym:1m:UST:tETHUST/last
+/v2/stats1/credits.size.sym:1m:UST:tETHUST/hist
 false
 [
   [

diff --git a/Bitfinex.Net.UnitTests/Endpoints/Spot/ExchangeData/GetFundingSize.txt b/Bitfinex.Net.UnitTests/Endpoints/Spot/ExchangeData/GetFundingSize.txt
@@ -1,5 +1,5 @@
 GET
-/v2/stats1/funding.size:1m:UST/last
+/v2/stats1/funding.size:1m:UST/hist
 false
 [
   [

diff --git a/Bitfinex.Net.UnitTests/Endpoints/Spot/ExchangeData/GetVolumeWeightedAveragePrice.txt b/Bitfinex.Net.UnitTests/Endpoints/Spot/ExchangeData/GetVolumeWeightedAveragePrice.txt
@@ -1,5 +1,5 @@
 GET
-/v2/stats1/vwap:1d:tETHUST/last
+/v2/stats1/vwap:1d:tETHUST/hist
 false
 [
   [

diff --git a/Bitfinex.Net.UnitTests/RestRequestTests.cs b/Bitfinex.Net.UnitTests/RestRequestTests.cs
@@ -87,12 +87,12 @@ public async Task ValidateSpotExchangeDataCalls()
             await tester.ValidateAsync(client => client.SpotApi.ExchangeData.GetDerivativesStatusHistoryAsync("tETHUST"), "GetDerivativesStatusHistory");
             await tester.ValidateAsync(client => client.SpotApi.ExchangeData.GetLiquidationsAsync(), "GetLiquidations", useSingleArrayItem: true);
             await tester.ValidateAsync(client => client.SpotApi.ExchangeData.GetFundingStatisticsAsync("tETHUST"), "GetFundingStatistics");
-            await tester.ValidateAsync(client => client.SpotApi.ExchangeData.GetFundingSizeAsync("UST", Enums.StatSection.Last), "GetFundingSize");
-            await tester.ValidateAsync(client => client.SpotApi.ExchangeData.GetCreditSizeAsync("UST", Enums.StatSection.Last), "GetCreditSize");
-            await tester.ValidateAsync(client => client.SpotApi.ExchangeData.GetCreditSizeAsync("UST", "tETHUST", Enums.StatSection.Last), "GetCreditSize2");
-            await tester.ValidateAsync(client => client.SpotApi.ExchangeData.GetLongsShortsTotalsAsync("tETHUST", Enums.StatSide.Long, Enums.StatSection.History), "GetLongsShortsTotals");
-            await tester.ValidateAsync(client => client.SpotApi.ExchangeData.GetTradingVolumeAsync(1, Enums.StatSection.History), "GetTradingVolume");
-            await tester.ValidateAsync(client => client.SpotApi.ExchangeData.GetVolumeWeightedAveragePriceAsync("tETHUST", Enums.StatSection.Last), "GetVolumeWeightedAveragePrice");
+            await tester.ValidateAsync(client => client.SpotApi.ExchangeData.GetFundingSizeHistoryAsync("UST"), "GetFundingSize");
+            await tester.ValidateAsync(client => client.SpotApi.ExchangeData.GetCreditSizeHistoryAsync("UST"), "GetCreditSize");
+            await tester.ValidateAsync(client => client.SpotApi.ExchangeData.GetCreditSizeHistoryAsync("UST", "tETHUST"), "GetCreditSize2");
+            await tester.ValidateAsync(client => client.SpotApi.ExchangeData.GetLongsShortsTotalsHistoryAsync("tETHUST", Enums.StatSide.Long), "GetLongsShortsTotals");
+            await tester.ValidateAsync(client => client.SpotApi.ExchangeData.GetTradingVolumeHistoryAsync(1), "GetTradingVolume");
+            await tester.ValidateAsync(client => client.SpotApi.ExchangeData.GetVolumeWeightedAveragePriceHistoryAsync("tETHUST"), "GetVolumeWeightedAveragePrice");
         }
 
         [Test]

diff --git a/Bitfinex.Net/Bitfinex.Net.csproj b/Bitfinex.Net/Bitfinex.Net.csproj
@@ -51,10 +51,10 @@
       <PrivateAssets>all</PrivateAssets>
       <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
     </PackageReference>
-    <PackageReference Include="CryptoExchange.Net" Version="7.9.0" />
     <PackageReference Include="Microsoft.CodeAnalysis.NetAnalyzers" Version="8.0.0">
       <PrivateAssets>all</PrivateAssets>
       <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
     </PackageReference>
+    <PackageReference Include="CryptoExchange.Net" Version="7.10.0" />
   </ItemGroup>
 </Project>