update dnn cfd project description #622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for being late here. There is still a bug in the |
pancetta
reviewed
Dec 11, 2023
_projects/dnn_cfd.md
Outdated
| head: lintermann_a | ||
| members: | ||
| - tsubokura_m | ||
| - onishi_k | ||
| - onishi_y |
There was a problem hiding this comment.
Are you sure about the change in the first name here? If so, you need to edit this in the database, too.
There was a problem hiding this comment.
thanks, I have updated the database accordingly
There was a problem hiding this comment.
Should I do the pull request again?
pancetta
reviewed
Dec 11, 2023
_data/people.yml
Outdated
| puri_r: | ||
| sur_name: Puri | ||
| given_name: Rishabh | ||
| affiliation: Engler-Bunte Institute - Combustion Technology, Karlsruhe Institute for Technology (KIT) |
There was a problem hiding this comment.
cannot have that name. Use external here
There was a problem hiding this comment.
OK, I have modified that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe we need to update the project members?
Rakesh, Rishabh, Onishi and Hadrien are new.