update gradle wrapper to 8.11.1 #819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update max gradle version for testing to 8.11.1 add gradle api version metadata to plugin artifact
wakingrufus
force-pushed
the
update-gradle
branch
from
0a10e72 to
025dfc5
Compare
wakingrufus
changed the title
JLLeitschuh
reviewed
Dec 12, 2024
| @@ -306,6 +306,12 @@ fun setupPublishingEnvironment() { | |||
|
|
|||
| setupPublishingEnvironment() | |||
|
|
|||
| configurations.named("implementation") { | |||
| attributes { | |||
| attribute(GradlePluginApiVersion.GRADLE_PLUGIN_API_VERSION_ATTRIBUTE, objects.named("7.4")) | |||
There was a problem hiding this comment.
What is this? Also, why is this version hard coded? What is it related to?
There was a problem hiding this comment.
It's a way of declaring gradle module metadata to express the minimum gradle API needed. Its similar to how gradle detects when you try to use a library compiled on jdk11 in a jdk8 project. https://docs.gradle.org/current/userguide/variant_attributes.html#sec:gradle-plugins-default-attributes
This way, we don't need to programmatically check the gradle version. The version i selected here aligns with the minimum gradle version we support and test against
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add gradle api version metadata to plugin artifact
update max gradle version for testing to 8.11.1