Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile for Java 11, including changes that NetBeans does #3

Closed
wants to merge 2 commits into from

Conversation

danielb987
Copy link

No description provided.

Note that com.sun.org.apache.xerces.internal.util.XMLCatalogResolver isn't available so I removed it from I18nChecker. It didn't seem cause any trouble.

However, it's used by the tests so I have commented the tests. So the test suite currently doesn't do anything.
@bobjacobsen
Copy link
Member

See PR #1 (which is very old). It seems to indicate that what we're using now in JMRI has some changes by @rhwood in the 'last-commit-in-phamernik-i18nchecker-PR-3' branch. A quick look at the comments on the commits makes it look like he's added a bunch of additional functionality.

@danielb987
Copy link
Author

See PR #1 (which is very old). It seems to indicate that what we're using now in JMRI has some changes by @rhwood in the 'last-commit-in-phamernik-i18nchecker-PR-3' branch. A quick look at the comments on the commits makes it look like he's added a bunch of additional functionality.

Thanks!

#5 compiles with Java 8 and fixes the bug that required allProperties="true" to be removed. The reason #1 wasn't merged is that master has a commit after #1 that makes it impossible to solve the merge conflict. The last commit in master should not go into #1 or #5.

Could you force merge #5?

I will see if I can find out why we get the spurious errors.

@danielb987
Copy link
Author

Closing this PR since it's replaced by #5.

@danielb987 danielb987 closed this Nov 28, 2022
@danielb987 danielb987 deleted the update_build_2 branch November 28, 2022 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants