Skip to content

Commit

Permalink
Use sha256 instead of md5 for cache key hash
Browse files Browse the repository at this point in the history
  • Loading branch information
JaJuMa committed Jan 6, 2022
1 parent 55bbe13 commit 054516d
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
4 changes: 1 addition & 3 deletions ViewModel/AwesomeSvgIcons.php
Original file line number Diff line number Diff line change
Expand Up @@ -91,9 +91,7 @@ public function renderHtml(
if (!empty($attributes)) {
foreach ($attributes as $key => $value) {
if (!empty($key)) {
// md5() here is not for cryptographic use.
// phpcs:ignore Magento2.Security.InsecureFunction
$cacheKey .= '_' . md5($key . $value);
$cacheKey .= '_' . sha256($key . $value);
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"description": "This Magento 2 extension allows using Font Awesome 5 icons with Hyvä Themes",
"type": "magento2-module",
"license": "MIT",
"version": "1.0.0",
"version": "1.0.1",
"authors": [
{
"email": "[email protected]",
Expand Down

0 comments on commit 054516d

Please sign in to comment.