Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes linker issue #13

Merged
merged 1 commit into from
Aug 23, 2024
Merged

Conversation

gabewillen
Copy link
Contributor

@gabewillen gabewillen commented Aug 22, 2024

First thank you for the excellent library and article with detailed benchmarks. When using this header with an extern struct defined which had a map field. I was getting the following linker issue

[build] duplicate symbol '_cc_omap_post_erase_fixup' in:
[build]     /VSCode/cc-cmake-issue/cmake-build-debug/CMakeFiles/test_cc_cmake_issue.dir/tests/test_cc_cmake_issue.c.o
[build]     libcc_cmake_issue.a[2](main.c.o)
[build] ld: 1 duplicate symbols

Changing the method signature to include static inline which matches the other function definitions resolved the issue.

@JacksonAllan
Copy link
Owner

Thanks for finding this bug! Certainly, that function should be static inline, like the others. I'll merge the pull request and issue a patch release ASAP.

@JacksonAllan JacksonAllan changed the base branch from main to dev August 23, 2024 14:17
@JacksonAllan JacksonAllan merged commit 0fce3f5 into JacksonAllan:dev Aug 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants