implement #9 issue, add support for Nova Event bus, trigger 'change' event #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JacobFitzp
requested changes
Dec 6, 2024
| @@ -27,7 +27,7 @@ class NovaExtension { | |||
| ...(webpackConfig.resolve.alias || {}), | |||
| 'laravel-nova': path.join( | |||
| __dirname, | |||
| 'vendor/laravel/nova/resources/js/mixins/packages.js' | |||
| '../../vendor/laravel/nova/resources/js/mixins/packages.js' | |||
There was a problem hiding this comment.
Suggested change
| '../../vendor/laravel/nova/resources/js/mixins/packages.js' | |
| 'vendor/laravel/nova/resources/js/mixins/packages.js' |
This reverts another change that was made
The path was updated from '../../vendor' to ensure the package functions correctly as a standalone package. This change aligns with the Laravel Nova documentation on mixins (part 2), which states that standalone packages should not depend on the main project structure.
There was a problem hiding this comment.
Hi,
Unfortunatly, I've got the issue with all my packages, and I don't know how to resolve it ... I work in nova-components directory but when I try to build package it never found laravel-nova alias so I must change the path.
If you give me a hand with this, I fix it quickly
Regards
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This PR add support for Nova Event bus and trigger 'change' event as explained #9 issue
Regards