bgg01590 #7
Open
bgg01590 #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KYankee6
reviewed
Jan 27, 2024
| return this.answer; | ||
| } | ||
|
|
||
| public String getAnswer() { |
|
|
||
| public void initAnswer(){ | ||
| this.answer = generateAnswer(); | ||
| System.out.println(this.answer); |
Jaeyoung22
reviewed
Jan 28, 2024
| import camp.nextstep.edu.missionutils.Randoms; | ||
|
|
||
| public class AnswerGenerator { | ||
| private String answer; |
There was a problem hiding this comment.
~~or, ~~er 등 역할의 이름으로 끝나는 클래스는 보통 util성 클래스가 많은 것으로 알고 있습니다.
generateAnswer()를 static 함수로 두고, String answer = AnswerGenerator.generate() 등으로 사용하는 방법은 어떨까요?
굳이 answer를 필드로 가지고 있지 않아도 될 것 같습니다!
| private final BaseballRuler baseballRuler; | ||
|
|
||
| public Baseball() { | ||
| this.answerGenerator = new AnswerGenerator(); |
There was a problem hiding this comment.
좋네요! 아직 스프링을 사용하지는 않지만 Baseball 생성자의 파라미터로 두 클래스를 두면 의존성 주입이 가능할 것 같습니다!
| int balls=0; | ||
| for (int i = 0; i < 3; i++) { | ||
| if (answer.contains(String.valueOf(input.charAt(i))) | ||
| && answer.charAt(i) != input.charAt(i)) { |
There was a problem hiding this comment.
이 로직이 위의 countStrikes 내부의 핵심 로직과 겹쳐서 보통 합치는 것으로 생각했는데, 이렇게 분리를 해도 깔끔한 것 같네요 :+1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
늦제출합니다 (_ _),,
통커밋도 죄송합니다 ㅁㅁ