Add clippy fixes #561
Merged
Add clippy fixes #561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a build erorr on commit 0f3122 and then fa0ef0
Merged
Shuzhengz
reviewed
Sep 30, 2024
| @@ -585,7 +591,7 @@ checksum = "f23ff5ef2b80d608d61efee834934d862cd92461afc0560dedf493e4c033738b" | |||
| dependencies = [ | |||
| "hermit-abi 0.3.9", | |||
| "libc", | |||
| "windows-sys", | |||
| "windows-sys 0.52.0", | |||
There was a problem hiding this comment.
wait why do we have windows-sys?
There was a problem hiding this comment.
I was confused about that too but I looked into it and it's now required by is-terminal. Maybe we replace is-terminal with a custom implementation that doesn't use imports?
There was a problem hiding this comment.
o huh thats weird, i think we can leave it in there for now but we should def make an issue to get rid of it later
There was a problem hiding this comment.
Sounds good. I made #567
Shuzhengz
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.