Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change format collect to string function #577

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Change format collect to string function #577

merged 1 commit into from
Jan 10, 2025

Conversation

JakeRoggenbuck
Copy link
Owner

fixes #571

Shuzhengz
Shuzhengz approved these changes Jan 10, 2025
View reviewed changes
Copy link
Collaborator

@Shuzhengz Shuzhengz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested and lgtm

@JakeRoggenbuck JakeRoggenbuck merged commit 07d9d15 into main Jan 10, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shuzhengz Shuzhengz Shuzhengz approved these changes

Assignees
No one assigned
Labels
Looking for Reviews Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix code scanning alert - use of format! to build up a string from an iterator
2 participants
@JakeRoggenbuck @Shuzhengz