bugfix: #247 array_min incorrect return value

#247
JamesHeinrich · May 21, 2020 · 13dc22a · 13dc22a
1 parent 581ee56
commit 13dc22a
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/getid3/getid3.lib.php b/getid3/getid3.lib.php
@@ -681,10 +681,10 @@ public static function CreateDeepArray($ArrayPath, $Separator, $Value) {
 	 */
 	public static function array_max($arraydata, $returnkey=false) {
 		$maxvalue = false;
-		$maxkey = false;
+		$maxkey   = false;
 		foreach ($arraydata as $key => $value) {
 			if (!is_array($value)) {
-				if ($value > $maxvalue) {
+				if (($maxvalue === false) || ($value > $maxvalue)) {
 					$maxvalue = $value;
 					$maxkey = $key;
 				}
@@ -701,10 +701,10 @@ public static function array_max($arraydata, $returnkey=false) {
 	 */
 	public static function array_min($arraydata, $returnkey=false) {
 		$minvalue = false;
-		$minkey = false;
+		$minkey   = false;
 		foreach ($arraydata as $key => $value) {
 			if (!is_array($value)) {
-				if ($value > $minvalue) {
+				if (($minvalue === false) || ($value < $minvalue)) {
 					$minvalue = $value;
 					$minkey = $key;
 				}

diff --git a/getid3/getid3.php b/getid3/getid3.php
@@ -257,7 +257,7 @@ class getID3
 	 */
 	protected $startup_warning = '';
 
-	const VERSION           = '1.9.19-202005171610';
+	const VERSION           = '1.9.19-202005202246';
 	const FREAD_BUFFER_SIZE = 32768;
 
 	const ATTACHMENTS_NONE   = false;