Compatibility fix for PHP 5.3 #435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. How long should we care about PHP5 compatibility? PHP7 has been out for 8 years now. |
|
The main problem is that in order to at least partially comply with the semver, we cannot remove unsupported PHP versions in the current major version; for this we will need to release a new major or at least 1.10 version. In 2.0 and my local 2.1, I long ago bumped the minimum version to PHP 7.2, but I can’t find the time to finalize 2.1 to a working state, I’m just merging all new commits from 1.9. :) |
|
Whenever you're ready for 2.1 I can also increment to 1.10 and match your minimum PHP version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Array dereferencing support was added only with PHP 5.4