Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review notes #12

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Review notes #12

wants to merge 13 commits into from

Conversation

sgharms
Copy link

@sgharms sgharms commented Jun 6, 2014

No description provided.

Steven G. Harms added 13 commits June 6, 2014 15:50
@sgharms
Copy link
Author

sgharms commented Jun 6, 2014

@JamieMcKenzie Here are my notes that I could put together on short notice

  • Clean up the code: whitespace, formatting, etc. These are giveaways about whether the interviewee is someone who doesn't make a mess in the break room ... or the code
  • Look into inversion of dependencies, it's a powerful technique that's stopping the OO-ness of your controller -> view binding
  • Try to get rid of that bundler

like: mvc approach, use of the document ready IIFE, etc.

@JamieMcKenzie
Copy link
Owner

Awesome. I'll take a look. Thanks for taking the time and we miss you!

Jamie McKenzie
Resume: JamieMcKenzie.github.io
LinkedIn/JamieMcKenzie http://linkedin.com/in/jamiemckenzie415
Github/JamieMcKenzie http://github.com/jamiemckenzie

On Fri, Jun 6, 2014 at 1:12 PM, Steven G. Harms [email protected]
wrote:

@JamieMcKenzie https://github.com/JamieMcKenzie Here are my notes that
I could put together on short notice

  • Clean up the code: whitespace, formatting, etc. These are giveaways
    about whether the interviewee is someone who doesn't make a mess in the
    break room ... or the code
  • Look into inversion of dependencies, it's a powerful technique
    that's stopping the OO-ness of your controller -> view binding
  • Try to get rid of that bundler

like: mvc approach, use of the document ready IIFE, etc.


Reply to this email directly or view it on GitHub
#12 (comment)
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants