Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing event grid client package #16

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

Removing event grid client package #16

wants to merge 5 commits into from

Conversation

jayendranarumugam
Copy link
Contributor

Addressing #12

Few things to consider in this PR:

  • I've assumed that the TopicEndpoint will be provided with the api-version, which means the config settings will looks like
{
"EventGridBindingSampleTopicEndpoint": "https://<name>.eventgrid.azure.net/api/events?api-version=2018-01-01"
}
  • I've created a new model called EventGridModel by inheriting the Event class. so that existing code won't break

@Jandev
Copy link
Owner

Jandev commented Oct 5, 2020

Looking great!

I've assumed that the TopicEndpoint will be provided with the api-version, which means the config settings will looks like

I'm fine with this, can you update the Readme with this, so it'll be clear to the users of the binding?

I'll do some testing & will probably push this as a 1.0 release once merged.

@jayendranarumugam jayendranarumugam marked this pull request as ready for review October 6, 2020 06:43
@jayendranarumugam
Copy link
Contributor Author

I've updated the readme with the settings. Please check and let me know if anything needs to address

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants