Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable codeintel in the IDE #98

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Enable codeintel in the IDE #98

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
187d8f2
[ubuntu-dev] install dependencies to enable codeintel
etiennewan Oct 8, 2017
66a6b77
[ubuntu-dev] dismiss the codeintel popup
etiennewan Oct 8, 2017
5358b24
[ubuntu-dev] codeintel: fix and cleanup
Oct 9, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions ubuntu-dev/ubuntu-dev.dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,6 +201,22 @@ RUN git clone https://github.com/kanaka/noVNC /home/user/.novnc/ \
&& cd /home/user/.novnc \
&& npm install \
&& node ./utils/use_require.js --as commonjs --with-app

# Install dependencies to enable codeintel (https://github.com/c9/c9.ide.language.codeintel)
RUN easy_install pip
&& pip install -U pip
&& pip install -U virtualenv
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: This will no longer be necessary when #97 is merged (it will already have the latest pip and virtualenv).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed considering #97

&& virtualenv --python=python2 $HOME/.c9/python2
&& source $HOME/.c9/python2/bin/activate
&& apt-get update
&& apt-get install python-dev
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: This shouldn't be necessary. If you need python-dev to be installed in the ubuntu-dev image, please add it to the list of installed packages at the top of this dockerfile.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moved python-dev to the top of file, I think it is indeed needed, but I'm not 100% sure

&& mkdir /tmp/codeintel
&& pip download -d /tmp/codeintel codeintel==0.9.3
&& cd /tmp/codeintel
&& tar xf CodeIntel-0.9.3.tar.gz
&& mv CodeIntel-0.9.3/SilverCity CodeIntel-0.9.3/silvercity
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, why are you renaming SilverCity to silvercity?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know much, I have to check https://github.com/c9/c9.ide.language.codeintel, that's what they advocate to do

&& tar czf CodeIntel-0.9.3.tar.gz CodeIntel-0.9.3
&& pip install -U --no-index --find-links=/tmp/codeintel codeintel
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Please delete the temporary /tmp/codeintel folder once you no longer need it. (And if some files need to be kept around for the installation to work, please move them somewhere under /home/user, e.g. as dotfiles or even better close to where it will be used, e.g. under a new folder in /home/user/.c9 as we do with noVNC).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They advocate to work under /tmp/ for this part, I assume pip does all the work, and nothing is necessary afterwards. done

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All these steps look like a very complicated way to do pip install codeintel==0.9.3. Wouldn't such a simple command work as well?


# Install the latest Cloud9 SDK with some useful IDE plugins.
RUN git clone https://github.com/c9/core.git /home/user/.c9sdk \
Expand Down
15 changes: 15 additions & 0 deletions ubuntu-dev/workspace-janitor.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,21 @@ module.exports = function (options) {

// Use a longer scrollback for the Terminal.
p.settings.user.terminal['@scrollback'] = 10000;

if (!p.settings.project) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Please add a comment similar to "Tweak the default user settings" above (ideally with a link to a file or list of every available project setting).

p.settings.user = {};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: You probably mean to create p.settings.project here, as opposed to p.settings.user.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

}

if (typeof p.settings.project === 'string') {
p.settings.project = JSON.parse(p.settings.project);
}

if (!p.settings.project.codeintel) {
p.settings.user.codeintel = {};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Same as above, s/user/project/.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

}

// Dismiss the codeintel popup because it's installed
p.settings.project.codeintel['@dismiss_installer'] = true;
}
break;
}
Expand Down