Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ${header} to 1.17+ export in Fabric Modded Entity Plugin #475

Merged
merged 2 commits into from
Apr 19, 2024

Conversation

FOREVEREALIZE
Copy link
Contributor

While the Fabric 1.14 and Fabric 1.15-1.16 exporters added the ${header} variable to the exported file, the Fabric 1.17+ did not. This PR addresses this issue.

@JannisX11
Copy link
Owner

You need to increase version numbers in plugins.json and in the plugin file in order to submit an update.

@fadookie for permission to merge.

@FOREVEREALIZE
Copy link
Contributor Author

You need to increase version numbers in plugins.json and in the plugin file in order to submit an update.

@fadookie for permission to merge.

Fixed.

@fadookie
Copy link
Contributor

I am not really maintaining this plugin anymore, as long as you've tested this change it's fine with me to merge. Thanks.

@FOREVEREALIZE
Copy link
Contributor Author

@JannisX11 Seems ready to merge to me!

@JannisX11 JannisX11 merged commit 13bb101 into JannisX11:master Apr 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants