Add seat options to sam3dj plugin #500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am not entirely sure about how to fix the weird number behavior when changing the vector. Could you also please bumb the minor number up in the version? |
|
Done! |
|
You just changed the patch number but I guess thats fine ^^' |
|
Please update plugins.json with the new plugin version |
|
Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 3dj format has been upgraded to make it possible for players to sit on 3d prints, this PR implements a simple boolean and vector options to make use of those options.
I'm not entirely happy with the vector field's behavior and it's tendency to go bonkers even when the steps are defined to 0.1, but eh, it is what it is.