Skip to content
This repository has been archived by the owner on Sep 12, 2024. It is now read-only.

check syntax no more explicitly need to call assertXXX #534

Merged
merged 5 commits into from
Aug 5, 2024

Conversation

ThakeeNathees
Copy link
Collaborator

Description

Jac source

image

Generated python source

image

Output

image

@ThakeeNathees ThakeeNathees requested a review from marsninja July 26, 2024 20:07
@ThakeeNathees
Copy link
Collaborator Author

I think we can go with something like bellow too, recursively but not sure.

test foo {
  check (1==2) and (2 <3);
}
assertEqual(1,2) and assertLess(2,3)

But this will be for a future improvement and we can mark it as a low priority todo.

Copy link
Contributor

@marsninja marsninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few quick things, but this pr is very good!!!

jaclang/compiler/passes/main/pyast_gen_pass.py Outdated Show resolved Hide resolved
jaclang/compiler/passes/main/pyast_gen_pass.py Outdated Show resolved Hide resolved
@ThakeeNathees ThakeeNathees requested a review from marsninja August 2, 2024 14:14
@marsninja marsninja merged commit 9ae0149 into main Aug 5, 2024
4 checks passed
@marsninja marsninja deleted the thakee-check-syntax branch August 5, 2024 15:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants