Skip to content
This repository has been archived by the owner on Sep 12, 2024. It is now read-only.

access check for symbols implemented #565

Merged
merged 12 commits into from
Aug 29, 2024
Merged

access check for symbols implemented #565

merged 12 commits into from
Aug 29, 2024

Conversation

ThakeeNathees
Copy link
Collaborator

No description provided.

@ThakeeNathees ThakeeNathees changed the title [WIP] access check for symbols implemented access check for symbols implemented Aug 17, 2024
mgtm98
mgtm98 previously approved these changes Aug 20, 2024
Copy link
Collaborator

@mgtm98 mgtm98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked the changes here and it looks good for me, still need to support the same pass with python classes but this can be tracked in another PR

@mgtm98
Copy link
Collaborator

mgtm98 commented Aug 20, 2024

Hi @marsninja, please check this PR, it's ready for now from my side. We need to merge it as there is a fix in it that I need in foolme

Copy link
Contributor

@marsninja marsninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice @ThakeeNathees , and thanks for providing guidance and review @mgtm98

@marsninja marsninja merged commit 242ebc9 into main Aug 29, 2024
4 checks passed
@marsninja marsninja deleted the thakee-access-pass branch August 29, 2024 13:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants