This repository has been archived by the owner on Sep 12, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThakeeNathees
force-pushed
the
thakee-access-pass
branch
from
August 14, 2024 11:01
c962245
to
16615e3
Compare
ThakeeNathees
changed the title
[WIP] access check for symbols implemented
access check for symbols implemented
Aug 17, 2024
…aclang into thakee-access-pass
ThakeeNathees
force-pushed
the
thakee-access-pass
branch
from
August 18, 2024 13:38
bbe6f8d
to
1f03729
Compare
mgtm98
previously approved these changes
Aug 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked the changes here and it looks good for me, still need to support the same pass with python classes but this can be tracked in another PR
Hi @marsninja, please check this PR, it's ready for now from my side. We need to merge it as there is a fix in it that I need in foolme |
marsninja
approved these changes
Aug 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice @ThakeeNathees , and thanks for providing guidance and review @mgtm98
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.