This repository has been archived by the owner on Sep 12, 2024. It is now read-only.
expression typeinfo implemented #586
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThakeeNathees
commented
Aug 24, 2024
| """Pass handler for DictCompr nodes.""" | ||
| mypy_node = node.gen.mypy_ast[0] | ||
| node.name_spec.sym_type = str(self.node_type_hash[mypy_node]) | ||
|
|
There was a problem hiding this comment.
These deleted methods are dynamically added above in init
ThakeeNathees
commented
Aug 24, 2024
| """Type check a member expr.""" | ||
| out = super().visit_member_expr(e, is_lvalue) | ||
| FuseTypeInfoPass.node_type_hash[e] = out | ||
| return out |
There was a problem hiding this comment.
All the visit_expr method are deleted as the logic are the same, and added as method bound when the instance is initialized at __init__ with also extrace the type info.
ThakeeNathees
force-pushed
the
thakee-expr-type
branch
from
b99ee72 to
6be016a
Compare
ThakeeNathees
force-pushed
the
thakee-expr-type
branch
from
6be016a to
a9c6a2b
Compare
|
Suppressed by : #590 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description