Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove port from Host header #353

Merged
merged 1 commit into from
Jan 4, 2024
Merged

Remove port from Host header #353

merged 1 commit into from
Jan 4, 2024

Conversation

bdraco
Copy link
Collaborator

@bdraco bdraco commented Jan 4, 2024

related issue home-assistant/core#107137

When we added happy eyeballs, I added the port, but this seems to cause problems for some devices

related issue home-assistant/core#107137

When we added happy eyeballs, I added the port, but this seems
to cause problems for some devices
Copy link

codecov bot commented Jan 4, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (eb209f6) 74.50% compared to head (51982f3) 74.50%.

Files Patch % Lines
aiohomekit/controller/ip/connection.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #353   +/-   ##
=======================================
  Coverage   74.50%   74.50%           
=======================================
  Files          99       99           
  Lines        9301     9301           
=======================================
  Hits         6930     6930           
  Misses       2371     2371           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@Jc2k Jc2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers

@bdraco bdraco marked this pull request as ready for review January 4, 2024 20:24
@bdraco bdraco merged commit 102b0ca into main Jan 4, 2024
8 of 9 checks passed
@bdraco bdraco deleted the drop_port branch January 4, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants