Implement async_reachable to see if a device is reachable on the network #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For zeroconf based devices we check if the A/AAAA records are still published. This means we will know if the device is offline within 120s since A/AAAA records typically have a TTL of 120s For BLE based devices we will check if the BLE device is in range and seen by the adapter. This will vary by BLE adapter, but it will likely mean we will know within a few minutes as well
bdraco
commented
Apr 26, 2024
| async with asyncio_timeout(timeout): | ||
| if discovery := await waiter: | ||
| return discovery | ||
| if discovery := await waiter: |
There was a problem hiding this comment.
There was a risk we could raise cancellation into the caller so I used a call later instead of async_timeout here
20 tasks
|
I need to write a test for the zeroconf case |
|
Keep getting distracted by beta issues so will have to come back to writing the tests later |
|
I've been running this for a few days, and all seems well here |
|
No crashes on the device now. I think this will solve the problem |
|
I haven't had one crash on the device since implementing this. This puts us much more in-line with the native HomeKit behavior. |
|
Retested with Jc2k SO_KEEPALIVE idea. All good 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For zeroconf based devices we check if the A/AAAA records are still published. This means we will know if the device is offline within 120s since A/AAAA records typically have a TTL of 120s
For BLE based devices we will check if the BLE device is in range and seen by the adapter. This will vary by BLE adapter, but it will likely mean we will know within a few minutes as well